Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py

Issue 11967019: [Android] Sever findbugs dependencies on environment variables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fit nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/android/pylib/utils/findbugs.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # This is used to test the findbugs plugin, it calls 7 # This is used to test the findbugs plugin, it calls
8 # build/android/pylib/findbugs.py to analyze the classes in 8 # build/android/pylib/utils/findbugs.py to analyze the classes in
9 # org.chromium.tools.findbugs.plugin package, and expects to get the same 9 # org.chromium.tools.findbugs.plugin package, and expects to get the same
10 # issue with those in expected_result.txt. 10 # issue with those in expected_result.txt.
11 # 11 #
12 # Useful command line: 12 # Useful command line:
13 # --rebaseline to generate the expected_result.txt, please make sure don't 13 # --rebaseline to generate the expected_result.txt, please make sure don't
14 # remove the expected result of exsting tests. 14 # remove the expected result of exsting tests.
15 15
16 16
17 import optparse 17 import optparse
18 import os 18 import os
19 import sys 19 import sys
20 20
21 lib_folder = os.path.join(os.getenv('CHROME_SRC'), 'build', 'android', 'pylib') 21 sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__),
22 if lib_folder not in sys.path: 22 '..', '..', '..', '..',
23 sys.path.append(lib_folder) 23 'build', 'android')))
24 24
25 import findbugs 25 from pylib import constants
26 from pylib.utils import findbugs
26 27
27 28
28 def main(argv): 29 def main(argv):
29 if not findbugs.CheckEnvironment():
30 return 1
31
32 parser = findbugs.GetCommonParser() 30 parser = findbugs.GetCommonParser()
33 31
34 options, _ = parser.parse_args() 32 options, _ = parser.parse_args()
35 33
36 chrome_src = os.getenv('CHROME_SRC')
37
38 if not options.known_bugs: 34 if not options.known_bugs:
39 options.known_bugs = os.path.join(chrome_src, 'tools', 'android', 35 options.known_bugs = os.path.join(constants.CHROME_DIR, 'tools', 'android',
40 'findbugs_plugin', 'test', 36 'findbugs_plugin', 'test',
41 'expected_result.txt') 37 'expected_result.txt')
42 if not options.only_analyze: 38 if not options.only_analyze:
43 options.only_analyze = 'org.chromium.tools.findbugs.plugin.*' 39 options.only_analyze = 'org.chromium.tools.findbugs.plugin.*'
44 40
45 return findbugs.Run(options) 41 return findbugs.Run(options)
46 42
47 if __name__ == '__main__': 43 if __name__ == '__main__':
48 sys.exit(main(sys.argv)) 44 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « build/android/pylib/utils/findbugs.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698