Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2906)

Unified Diff: build/android/findbugs_diff.py

Issue 11967019: [Android] Sever findbugs dependencies on environment variables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fit nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/constants.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/findbugs_diff.py
diff --git a/build/android/findbugs_diff.py b/build/android/findbugs_diff.py
index eb49824ef2375c1c013a31ea607a8da4cb55b8a2..4dc67428ee61d2e6bbb49105cff03fa3120e0e16 100755
--- a/build/android/findbugs_diff.py
+++ b/build/android/findbugs_diff.py
@@ -28,21 +28,17 @@ import optparse
import os
import sys
-from pylib import findbugs
+from pylib import constants
+from pylib.utils import findbugs
def main(argv):
- if not findbugs.CheckEnvironment():
- return 1
-
parser = findbugs.GetCommonParser()
options, _ = parser.parse_args()
- chrome_src = os.getenv('CHROME_SRC')
-
if not options.base_dir:
- options.base_dir = os.path.join(chrome_src, 'build', 'android',
+ options.base_dir = os.path.join(constants.CHROME_DIR, 'build', 'android',
'findbugs_filter')
if not options.only_analyze:
options.only_analyze = 'org.chromium.-'
« no previous file with comments | « no previous file | build/android/pylib/constants.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698