Revert "cc: Make tiling interest rect calc based on viewport."

Revert "cc: Make tiling interest rect calc based on viewport."

This reverts commit 6d84db54a27c036d77b0e4a26d42c158ee4a6add.

Reason for revert:
This creates perf regression with top-control and viewport resizes on android (creates and deletes extra tiles).

TBR=vmpstr@chromium.org

BUG=502432
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0fba32ceb135da0931a4e3b4cd14c07f66634b3a
Cr-Commit-Position: refs/heads/master@{#335971}

[sohanjg, 2015-06-23 08:47:57]

The CQ bit was checked by sohan.jyoti@samsung.com

[commit-bot: I haz the power, 2015-06-23 08:48:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196553009/1

[commit-bot: I haz the power, 2015-06-23 08:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 08:48:34]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[sohanjg, 2015-06-23 08:55:48]

The CQ bit was checked by sohan.jyoti@samsung.com

[commit-bot: I haz the power, 2015-06-23 08:56:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196553009/1

[commit-bot: I haz the power, 2015-06-23 09:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 09:17:34]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sohanjg, 2015-06-23 09:40:55]

sohan.jyoti@samsung.com changed reviewers:
+ vmpstr@chromium.org

[sohanjg, 2015-06-23 09:43:46]

On 2015/06/23 09:17:34, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Vlad@, I think you had added LayerTreeSettingsWithLargeInterestArea in the perf
tests as a follow-up. Better you take a look, before i revert them.
thanks.

[jdduke (slow), 2015-06-23 14:57:13]

On 2015/06/23 09:43:46, sohanjg wrote:
> On 2015/06/23 09:17:34, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> 
> Vlad@, I think you had added LayerTreeSettingsWithLargeInterestArea in the
perf
> tests as a follow-up. Better you take a look, before i revert them.
> thanks.

Depending on the cc/tiles refactoring timing, for M44 it might be easier to
revert directly rather than cherry-picking the (conflicting) revert here.

[vmpstr, 2015-06-23 16:39:47]

https://codereview.chromium.org/1196553009/diff/20001/cc/tiles/tile_manager_p...
File cc/tiles/tile_manager_perftest.cc (left):

https://codereview.chromium.org/1196553009/diff/20001/cc/tiles/tile_manager_p...
cc/tiles/tile_manager_perftest.cc:87: class
LayerTreeSettingsWithLargeInterestArea : public LayerTreeSettings {
This was a part of making impl side painting default. I assume perftests all
pass, right? (there's some EXPECTs to ensure that we've processed enough files).

https://codereview.chromium.org/1196553009/diff/20001/cc/trees/layer_tree_set...
File cc/trees/layer_tree_settings.h (right):

https://codereview.chromium.org/1196553009/diff/20001/cc/trees/layer_tree_set...
cc/trees/layer_tree_settings.h:70: bool use_pinch_zoom_scrollbars;
I don't think these two bools aren't a part of the revert.

[sohanjg, 2015-06-23 17:08:00]

Do you want us to go ahead with this revert ? jdduke@ wanted to do it m44
directly.

https://codereview.chromium.org/1196553009/diff/20001/cc/tiles/tile_manager_p...
File cc/tiles/tile_manager_perftest.cc (left):

https://codereview.chromium.org/1196553009/diff/20001/cc/tiles/tile_manager_p...
cc/tiles/tile_manager_perftest.cc:87: class
LayerTreeSettingsWithLargeInterestArea : public LayerTreeSettings {
On 2015/06/23 16:39:47, vmpstr wrote:
> This was a part of making impl side painting default. I assume perftests all
> pass, right? (there's some EXPECTs to ensure that we've processed enough
files).

There was error in building cc_perftest bcz of this, as the multiplier has been
removed from layertreesettings.

https://codereview.chromium.org/1196553009/diff/20001/cc/trees/layer_tree_set...
File cc/trees/layer_tree_settings.h (right):

https://codereview.chromium.org/1196553009/diff/20001/cc/trees/layer_tree_set...
cc/trees/layer_tree_settings.h:70: bool use_pinch_zoom_scrollbars;
On 2015/06/23 16:39:47, vmpstr wrote:
> I don't think these two bools aren't a part of the revert.

Ahh..this somehow creeped in. Will remove.

[vmpstr, 2015-06-23 17:12:04]

On 2015/06/23 17:08:00, sohanjg wrote:
> Do you want us to go ahead with this revert ? jdduke@ wanted to do it m44
> directly.
> 

If this is an issue in M44, it means that it's also an issue on ToT, so I think
we should revert on both. Whether we cherry pick to m44 or do a separate revert,
I don't really have a preference.

>
https://codereview.chromium.org/1196553009/diff/20001/cc/tiles/tile_manager_p...
> File cc/tiles/tile_manager_perftest.cc (left):
> 
>
https://codereview.chromium.org/1196553009/diff/20001/cc/tiles/tile_manager_p...
> cc/tiles/tile_manager_perftest.cc:87: class
> LayerTreeSettingsWithLargeInterestArea : public LayerTreeSettings {
> On 2015/06/23 16:39:47, vmpstr wrote:
> > This was a part of making impl side painting default. I assume perftests all
> > pass, right? (there's some EXPECTs to ensure that we've processed enough
> files).
> 
> There was error in building cc_perftest bcz of this, as the multiplier has
been
> removed from layertreesettings.
> 
>
https://codereview.chromium.org/1196553009/diff/20001/cc/trees/layer_tree_set...
> File cc/trees/layer_tree_settings.h (right):
> 
>
https://codereview.chromium.org/1196553009/diff/20001/cc/trees/layer_tree_set...
> cc/trees/layer_tree_settings.h:70: bool use_pinch_zoom_scrollbars;
> On 2015/06/23 16:39:47, vmpstr wrote:
> > I don't think these two bools aren't a part of the revert.
> 
> Ahh..this somehow creeped in. Will remove.

[jdduke (slow), 2015-06-23 23:51:17]

On 2015/06/23 17:12:04, vmpstr wrote:
> On 2015/06/23 17:08:00, sohanjg wrote:
> > Do you want us to go ahead with this revert ? jdduke@ wanted to do it m44
> > directly.
> > 
> 
> If this is an issue in M44, it means that it's also an issue on ToT, so I
think
> we should revert on both. Whether we cherry pick to m44 or do a separate
revert,
> I don't really have a preference.

Right, I didn't mean we should only revert in M44, just that it might be easier
to directly revert on M44. Just as vmiura@ said, we'll want to revert both on
ToT and M44.

[sohanjg, 2015-06-24 05:18:55]

Patchset #3 (id:40001) has been deleted

[sohanjg, 2015-06-24 05:31:21]

Patchset #3 (id:60001) has been deleted

[sohanjg, 2015-06-24 05:43:06]

On 2015/06/23 23:51:17, jdduke wrote:
> On 2015/06/23 17:12:04, vmpstr wrote:
> > On 2015/06/23 17:08:00, sohanjg wrote:
> > > Do you want us to go ahead with this revert ? jdduke@ wanted to do it m44
> > > directly.
> > > 
> > 
> > If this is an issue in M44, it means that it's also an issue on ToT, so I
> think
> > we should revert on both. Whether we cherry pick to m44 or do a separate
> revert,
> > I don't really have a preference.
> 
> Right, I didn't mean we should only revert in M44, just that it might be
easier
> to directly revert on M44. Just as vmiura@ said, we'll want to revert both on
> ToT and M44.

Its vmpstr@, not vmiura@ :)

Please have a look before we commit it. thanks.

[vmpstr, 2015-06-24 18:02:12]

lgtm

[sohanjg, 2015-06-24 18:17:00]

The CQ bit was checked by sohan.jyoti@samsung.com

[commit-bot: I haz the power, 2015-06-24 18:18:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196553009/80001

[commit-bot: I haz the power, 2015-06-24 19:16:46]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-06-24 19:17:53]

Patchset 3 (id:??) landed as
https://crrev.com/0fba32ceb135da0931a4e3b4cd14c07f66634b3a
Cr-Commit-Position: refs/heads/master@{#335971}

[jdduke (slow), 2015-06-24 19:36:24]

On 2015/06/24 05:43:06, sohanjg wrote:
> Its vmpstr@, not vmiura@ :)
> 
> Please have a look before we commit it. thanks.

Too many vm's =/

[sohanjg, 2015-11-18 10:29:41]

Description was changed from

==========
Revert "cc: Make tiling interest rect calc based on viewport."

This reverts commit 6d84db54a27c036d77b0e4a26d42c158ee4a6add.

Reason for revert:
This creates perf regression with top-control and viewport resizes on android
(creates and deletes extra tiles).

TBR=vmpstr@chromium.org

BUG=502432
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0fba32ceb135da0931a4e3b4cd14c07f66634b3a
Cr-Commit-Position: refs/heads/master@{#335971}
==========

to

==========
Revert "cc: Make tiling interest rect calc based on viewport."

This reverts commit 6d84db54a27c036d77b0e4a26d42c158ee4a6add.

Reason for revert:
This creates perf regression with top-control and viewport resizes on android
(creates and deletes extra tiles).

TBR=vmpstr@chromium.org

BUG=502432
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0fba32ceb135da0931a4e3b4cd14c07f66634b3a
Cr-Commit-Position: refs/heads/master@{#335971}
==========