Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: cc/tiles/picture_layer_tiling_set.cc

Issue 1196553009: Revert "cc: Make tiling interest rect calc based on viewport." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert extra bools. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/tiles/picture_layer_tiling_set.h ('k') | cc/tiles/picture_layer_tiling_set_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/tiles/picture_layer_tiling_set.h" 5 #include "cc/tiles/picture_layer_tiling_set.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 15 matching lines...) Expand all
26 DCHECK_GT(float2, 0.f); 26 DCHECK_GT(float2, 0.f);
27 return float1 > float2 ? float1 / float2 : float2 / float1; 27 return float1 > float2 ? float1 / float2 : float2 / float1;
28 } 28 }
29 29
30 } // namespace 30 } // namespace
31 31
32 // static 32 // static
33 scoped_ptr<PictureLayerTilingSet> PictureLayerTilingSet::Create( 33 scoped_ptr<PictureLayerTilingSet> PictureLayerTilingSet::Create(
34 WhichTree tree, 34 WhichTree tree,
35 PictureLayerTilingClient* client, 35 PictureLayerTilingClient* client,
36 float tiling_interest_area_viewport_multiplier, 36 size_t max_tiles_for_interest_area,
37 float skewport_target_time_in_seconds, 37 float skewport_target_time_in_seconds,
38 int skewport_extrapolation_limit_in_content_pixels) { 38 int skewport_extrapolation_limit_in_content_pixels) {
39 return make_scoped_ptr(new PictureLayerTilingSet( 39 return make_scoped_ptr(new PictureLayerTilingSet(
40 tree, client, tiling_interest_area_viewport_multiplier, 40 tree, client, max_tiles_for_interest_area,
41 skewport_target_time_in_seconds, 41 skewport_target_time_in_seconds,
42 skewport_extrapolation_limit_in_content_pixels)); 42 skewport_extrapolation_limit_in_content_pixels));
43 } 43 }
44 44
45 PictureLayerTilingSet::PictureLayerTilingSet( 45 PictureLayerTilingSet::PictureLayerTilingSet(
46 WhichTree tree, 46 WhichTree tree,
47 PictureLayerTilingClient* client, 47 PictureLayerTilingClient* client,
48 float tiling_interest_area_viewport_multiplier, 48 size_t max_tiles_for_interest_area,
49 float skewport_target_time_in_seconds, 49 float skewport_target_time_in_seconds,
50 int skewport_extrapolation_limit_in_content_pixels) 50 int skewport_extrapolation_limit_in_content_pixels)
51 : tiling_interest_area_viewport_multiplier_( 51 : max_tiles_for_interest_area_(max_tiles_for_interest_area),
52 tiling_interest_area_viewport_multiplier),
53 skewport_target_time_in_seconds_(skewport_target_time_in_seconds), 52 skewport_target_time_in_seconds_(skewport_target_time_in_seconds),
54 skewport_extrapolation_limit_in_content_pixels_( 53 skewport_extrapolation_limit_in_content_pixels_(
55 skewport_extrapolation_limit_in_content_pixels), 54 skewport_extrapolation_limit_in_content_pixels),
56 tree_(tree), 55 tree_(tree),
57 client_(client) { 56 client_(client) {
58 } 57 }
59 58
60 PictureLayerTilingSet::~PictureLayerTilingSet() { 59 PictureLayerTilingSet::~PictureLayerTilingSet() {
61 } 60 }
62 61
63 void PictureLayerTilingSet::CopyTilingsAndPropertiesFromPendingTwin( 62 void PictureLayerTilingSet::CopyTilingsAndPropertiesFromPendingTwin(
64 const PictureLayerTilingSet* pending_twin_set, 63 const PictureLayerTilingSet* pending_twin_set,
65 const scoped_refptr<RasterSource>& raster_source, 64 const scoped_refptr<RasterSource>& raster_source,
66 const Region& layer_invalidation) { 65 const Region& layer_invalidation) {
67 if (pending_twin_set->tilings_.empty()) { 66 if (pending_twin_set->tilings_.empty()) {
68 // If the twin (pending) tiling set is empty, it was not updated for the 67 // If the twin (pending) tiling set is empty, it was not updated for the
69 // current frame. So we drop tilings from our set as well, instead of 68 // current frame. So we drop tilings from our set as well, instead of
70 // leaving behind unshared tilings that are all non-ideal. 69 // leaving behind unshared tilings that are all non-ideal.
71 RemoveAllTilings(); 70 RemoveAllTilings();
72 return; 71 return;
73 } 72 }
74 73
75 bool tiling_sort_required = false; 74 bool tiling_sort_required = false;
76 for (PictureLayerTiling* pending_twin_tiling : pending_twin_set->tilings_) { 75 for (PictureLayerTiling* pending_twin_tiling : pending_twin_set->tilings_) {
77 float contents_scale = pending_twin_tiling->contents_scale(); 76 float contents_scale = pending_twin_tiling->contents_scale();
78 PictureLayerTiling* this_tiling = FindTilingWithScale(contents_scale); 77 PictureLayerTiling* this_tiling = FindTilingWithScale(contents_scale);
79 if (!this_tiling) { 78 if (!this_tiling) {
80 scoped_ptr<PictureLayerTiling> new_tiling = PictureLayerTiling::Create( 79 scoped_ptr<PictureLayerTiling> new_tiling = PictureLayerTiling::Create(
81 tree_, contents_scale, raster_source, client_, 80 tree_, contents_scale, raster_source, client_,
82 tiling_interest_area_viewport_multiplier_, 81 max_tiles_for_interest_area_, skewport_target_time_in_seconds_,
83 skewport_target_time_in_seconds_,
84 skewport_extrapolation_limit_in_content_pixels_); 82 skewport_extrapolation_limit_in_content_pixels_);
85 tilings_.push_back(new_tiling.Pass()); 83 tilings_.push_back(new_tiling.Pass());
86 this_tiling = tilings_.back(); 84 this_tiling = tilings_.back();
87 tiling_sort_required = true; 85 tiling_sort_required = true;
88 } 86 }
89 this_tiling->TakeTilesAndPropertiesFrom(pending_twin_tiling, 87 this_tiling->TakeTilesAndPropertiesFrom(pending_twin_tiling,
90 layer_invalidation); 88 layer_invalidation);
91 } 89 }
92 90
93 if (tiling_sort_required) 91 if (tiling_sort_required)
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 PictureLayerTiling* PictureLayerTilingSet::AddTiling( 252 PictureLayerTiling* PictureLayerTilingSet::AddTiling(
255 float contents_scale, 253 float contents_scale,
256 scoped_refptr<RasterSource> raster_source) { 254 scoped_refptr<RasterSource> raster_source) {
257 for (size_t i = 0; i < tilings_.size(); ++i) { 255 for (size_t i = 0; i < tilings_.size(); ++i) {
258 DCHECK_NE(tilings_[i]->contents_scale(), contents_scale); 256 DCHECK_NE(tilings_[i]->contents_scale(), contents_scale);
259 DCHECK_EQ(tilings_[i]->raster_source(), raster_source.get()); 257 DCHECK_EQ(tilings_[i]->raster_source(), raster_source.get());
260 } 258 }
261 259
262 tilings_.push_back(PictureLayerTiling::Create( 260 tilings_.push_back(PictureLayerTiling::Create(
263 tree_, contents_scale, raster_source, client_, 261 tree_, contents_scale, raster_source, client_,
264 tiling_interest_area_viewport_multiplier_, 262 max_tiles_for_interest_area_, skewport_target_time_in_seconds_,
265 skewport_target_time_in_seconds_,
266 skewport_extrapolation_limit_in_content_pixels_)); 263 skewport_extrapolation_limit_in_content_pixels_));
267 PictureLayerTiling* appended = tilings_.back(); 264 PictureLayerTiling* appended = tilings_.back();
268 265
269 tilings_.sort(LargestToSmallestScaleFunctor()); 266 tilings_.sort(LargestToSmallestScaleFunctor());
270 return appended; 267 return appended;
271 } 268 }
272 269
273 int PictureLayerTilingSet::NumHighResTilings() const { 270 int PictureLayerTilingSet::NumHighResTilings() const {
274 return std::count_if(tilings_.begin(), tilings_.end(), 271 return std::count_if(tilings_.begin(), tilings_.end(),
275 [](PictureLayerTiling* tiling) { 272 [](PictureLayerTiling* tiling) {
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 case LOWER_THAN_LOW_RES: 584 case LOWER_THAN_LOW_RES:
588 range = TilingRange(low_res_range.end, tilings_size); 585 range = TilingRange(low_res_range.end, tilings_size);
589 break; 586 break;
590 } 587 }
591 588
592 DCHECK_LE(range.start, range.end); 589 DCHECK_LE(range.start, range.end);
593 return range; 590 return range;
594 } 591 }
595 592
596 } // namespace cc 593 } // namespace cc
OLDNEW
« no previous file with comments | « cc/tiles/picture_layer_tiling_set.h ('k') | cc/tiles/picture_layer_tiling_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698