Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: cc/tiles/tile_manager_unittest.cc

Issue 1196553009: Revert "cc: Make tiling interest rect calc based on viewport." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert extra bools. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/tiles/tile_manager_perftest.cc ('k') | cc/trees/layer_tree_settings.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/thread_task_runner_handle.h" 5 #include "base/thread_task_runner_handle.h"
6 #include "cc/resources/resource_pool.h" 6 #include "cc/resources/resource_pool.h"
7 #include "cc/test/begin_frame_args_test.h" 7 #include "cc/test/begin_frame_args_test.h"
8 #include "cc/test/fake_impl_proxy.h" 8 #include "cc/test/fake_impl_proxy.h"
9 #include "cc/test/fake_layer_tree_host_impl.h" 9 #include "cc/test/fake_layer_tree_host_impl.h"
10 #include "cc/test/fake_output_surface.h" 10 #include "cc/test/fake_output_surface.h"
(...skipping 11 matching lines...) Expand all
22 #include "cc/tiles/tile_priority.h" 22 #include "cc/tiles/tile_priority.h"
23 #include "cc/tiles/tiling_set_raster_queue_all.h" 23 #include "cc/tiles/tiling_set_raster_queue_all.h"
24 #include "cc/trees/layer_tree_impl.h" 24 #include "cc/trees/layer_tree_impl.h"
25 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
26 26
27 namespace cc { 27 namespace cc {
28 namespace { 28 namespace {
29 29
30 class LowResTilingsSettings : public LayerTreeSettings { 30 class LowResTilingsSettings : public LayerTreeSettings {
31 public: 31 public:
32 LowResTilingsSettings() { 32 LowResTilingsSettings() { create_low_res_tiling = true; }
33 tiling_interest_area_viewport_multiplier = 10000;
34 create_low_res_tiling = true;
35 }
36 }; 33 };
37 34
38 class TileManagerTilePriorityQueueTest : public testing::Test { 35 class TileManagerTilePriorityQueueTest : public testing::Test {
39 public: 36 public:
40 TileManagerTilePriorityQueueTest() 37 TileManagerTilePriorityQueueTest()
41 : memory_limit_policy_(ALLOW_ANYTHING), 38 : memory_limit_policy_(ALLOW_ANYTHING),
42 max_tiles_(10000), 39 max_tiles_(10000),
43 ready_to_activate_(false), 40 ready_to_activate_(false),
44 id_(7), 41 id_(7),
45 proxy_(base::ThreadTaskRunnerHandle::Get()), 42 proxy_(base::ThreadTaskRunnerHandle::Get()),
(...skipping 1109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1155 1152
1156 gfx::Rect viewport(50, 50, 500, 500); 1153 gfx::Rect viewport(50, 50, 500, 500);
1157 gfx::Size layer_bounds(1600, 1600); 1154 gfx::Size layer_bounds(1600, 1600);
1158 1155
1159 float inset = PictureLayerTiling::CalculateSoonBorderDistance(viewport, 1.0f); 1156 float inset = PictureLayerTiling::CalculateSoonBorderDistance(viewport, 1.0f);
1160 gfx::Rect soon_rect = viewport; 1157 gfx::Rect soon_rect = viewport;
1161 soon_rect.Inset(-inset, -inset); 1158 soon_rect.Inset(-inset, -inset);
1162 1159
1163 client.SetTileSize(gfx::Size(30, 30)); 1160 client.SetTileSize(gfx::Size(30, 30));
1164 LayerTreeSettings settings; 1161 LayerTreeSettings settings;
1165 settings.tiling_interest_area_viewport_multiplier = 10000; 1162 settings.max_tiles_for_interest_area = 10000;
1166 1163
1167 scoped_ptr<PictureLayerTilingSet> tiling_set = PictureLayerTilingSet::Create( 1164 scoped_ptr<PictureLayerTilingSet> tiling_set = PictureLayerTilingSet::Create(
1168 ACTIVE_TREE, &client, settings.tiling_interest_area_viewport_multiplier, 1165 ACTIVE_TREE, &client, settings.max_tiles_for_interest_area,
1169 settings.skewport_target_time_in_seconds, 1166 settings.skewport_target_time_in_seconds,
1170 settings.skewport_extrapolation_limit_in_content_pixels); 1167 settings.skewport_extrapolation_limit_in_content_pixels);
1171 1168
1172 scoped_refptr<FakePicturePileImpl> pile = 1169 scoped_refptr<FakePicturePileImpl> pile =
1173 FakePicturePileImpl::CreateFilledPileWithDefaultTileSize(layer_bounds); 1170 FakePicturePileImpl::CreateFilledPileWithDefaultTileSize(layer_bounds);
1174 PictureLayerTiling* tiling = tiling_set->AddTiling(1.0f, pile); 1171 PictureLayerTiling* tiling = tiling_set->AddTiling(1.0f, pile);
1175 tiling->set_resolution(HIGH_RESOLUTION); 1172 tiling->set_resolution(HIGH_RESOLUTION);
1176 1173
1177 tiling_set->UpdateTilePriorities(viewport, 1.0f, 1.0, Occlusion(), true); 1174 tiling_set->UpdateTilePriorities(viewport, 1.0f, 1.0, Occlusion(), true);
1178 std::vector<Tile*> all_tiles = tiling->AllTilesForTesting(); 1175 std::vector<Tile*> all_tiles = tiling->AllTilesForTesting();
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
1265 TEST_F(TileManagerTilePriorityQueueTest, 1262 TEST_F(TileManagerTilePriorityQueueTest,
1266 RasterTilePriorityQueueMovingViewport) { 1263 RasterTilePriorityQueueMovingViewport) {
1267 FakePictureLayerTilingClient client; 1264 FakePictureLayerTilingClient client;
1268 1265
1269 gfx::Rect viewport(50, 0, 100, 100); 1266 gfx::Rect viewport(50, 0, 100, 100);
1270 gfx::Rect moved_viewport(50, 0, 100, 500); 1267 gfx::Rect moved_viewport(50, 0, 100, 500);
1271 gfx::Size layer_bounds(1000, 1000); 1268 gfx::Size layer_bounds(1000, 1000);
1272 1269
1273 client.SetTileSize(gfx::Size(30, 30)); 1270 client.SetTileSize(gfx::Size(30, 30));
1274 LayerTreeSettings settings; 1271 LayerTreeSettings settings;
1272 settings.max_tiles_for_interest_area = 10000;
1275 1273
1276 scoped_ptr<PictureLayerTilingSet> tiling_set = PictureLayerTilingSet::Create( 1274 scoped_ptr<PictureLayerTilingSet> tiling_set = PictureLayerTilingSet::Create(
1277 ACTIVE_TREE, &client, settings.tiling_interest_area_viewport_multiplier, 1275 ACTIVE_TREE, &client, settings.max_tiles_for_interest_area,
1278 settings.skewport_target_time_in_seconds, 1276 settings.skewport_target_time_in_seconds,
1279 settings.skewport_extrapolation_limit_in_content_pixels); 1277 settings.skewport_extrapolation_limit_in_content_pixels);
1280 1278
1281 scoped_refptr<FakePicturePileImpl> pile = 1279 scoped_refptr<FakePicturePileImpl> pile =
1282 FakePicturePileImpl::CreateFilledPileWithDefaultTileSize(layer_bounds); 1280 FakePicturePileImpl::CreateFilledPileWithDefaultTileSize(layer_bounds);
1283 PictureLayerTiling* tiling = tiling_set->AddTiling(1.0f, pile); 1281 PictureLayerTiling* tiling = tiling_set->AddTiling(1.0f, pile);
1284 tiling->set_resolution(HIGH_RESOLUTION); 1282 tiling->set_resolution(HIGH_RESOLUTION);
1285 1283
1286 tiling_set->UpdateTilePriorities(viewport, 1.0f, 1.0, Occlusion(), true); 1284 tiling_set->UpdateTilePriorities(viewport, 1.0f, 1.0, Occlusion(), true);
1287 tiling_set->UpdateTilePriorities(moved_viewport, 1.0f, 2.0, Occlusion(), 1285 tiling_set->UpdateTilePriorities(moved_viewport, 1.0f, 2.0, Occlusion(),
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
1459 non_intersecting_rect, // Soon rect. 1457 non_intersecting_rect, // Soon rect.
1460 intersecting_rect); // Eventually rect. 1458 intersecting_rect); // Eventually rect.
1461 scoped_ptr<TilingSetRasterQueueAll> queue( 1459 scoped_ptr<TilingSetRasterQueueAll> queue(
1462 new TilingSetRasterQueueAll(tiling_set.get(), false)); 1460 new TilingSetRasterQueueAll(tiling_set.get(), false));
1463 EXPECT_FALSE(queue->IsEmpty()); 1461 EXPECT_FALSE(queue->IsEmpty());
1464 } 1462 }
1465 } 1463 }
1466 1464
1467 } // namespace 1465 } // namespace
1468 } // namespace cc 1466 } // namespace cc
OLDNEW
« no previous file with comments | « cc/tiles/tile_manager_perftest.cc ('k') | cc/trees/layer_tree_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698