Issue 1196543003: Remove handles from ElementsAccessor::Set and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1196543003: Remove handles from ElementsAccessor::Set and friends (Closed)

Created:
5 years, 6 months ago by Toon Verwaest

Modified:
5 years, 6 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove handles from ElementsAccessor::Set and friends BUG=v8:4137 LOG=n Committed: https://crrev.com/0f1522f4c23295afde5eb3151afb96c96f826deb Cr-Commit-Position: refs/heads/master@{#29139}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -96 lines)			Patch
M	src/elements.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/elements.cc	View	3 chunks	+13 lines, -17 lines	0 comments	Download
M	src/lookup.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/objects.h	View	12 chunks	+12 lines, -24 lines	0 comments	Download
M	src/objects.cc	View	5 chunks	+31 lines, -45 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196543003/1

5 years, 6 months ago (2015-06-19 08:56:17 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-19 09:25:33 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0f1522f4c23295afde5eb3151afb96c96f826deb
Cr-Commit-Position: refs/heads/master@{#29139}