Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: src/objects-inl.h

Issue 1196543003: Remove handles from ElementsAccessor::Set and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index db02e615662333147a3b6ac21c461253586ba42d..203f152d9bc2e882e31cd515341e1419c47fe030 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -4002,21 +4002,20 @@ Handle<Object> FixedTypedArray<Traits>::get(
template <class Traits>
-void FixedTypedArray<Traits>::SetValue(Handle<FixedTypedArray<Traits> > array,
- uint32_t index, Handle<Object> value) {
+void FixedTypedArray<Traits>::SetValue(uint32_t index, Object* value) {
ElementType cast_value = Traits::defaultValue();
if (value->IsSmi()) {
- int int_value = Handle<Smi>::cast(value)->value();
+ int int_value = Smi::cast(value)->value();
cast_value = from_int(int_value);
} else if (value->IsHeapNumber()) {
- double double_value = Handle<HeapNumber>::cast(value)->value();
+ double double_value = HeapNumber::cast(value)->value();
cast_value = from_double(double_value);
} else {
// Clamp undefined to the default value. All other types have been
// converted to a number type further up in the call chain.
DCHECK(value->IsUndefined());
}
- array->set(index, cast_value);
+ set(index, cast_value);
}
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698