Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: src/objects.h

Issue 1196543003: Remove handles from ElementsAccessor::Set and friends (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 3cba6df84d7d70ff37d8e1f1885e4f403a9af749..4f73eb42e7a057a77db18a8af84dd7a98773b508 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -2439,8 +2439,7 @@ class FixedArray: public FixedArrayBase {
public:
// Setter and getter for elements.
inline Object* get(int index) const;
- static void SetValue(Handle<FixedArray> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
static inline Handle<Object> get(Handle<FixedArray> array, int index);
// Setter that uses write barrier.
inline void set(int index, Object* value);
@@ -2563,8 +2562,7 @@ class FixedDoubleArray: public FixedArrayBase {
inline uint64_t get_representation(int index);
static inline Handle<Object> get(Handle<FixedDoubleArray> array, int index);
// This accessor has to get a Number as |value|.
- static void SetValue(Handle<FixedDoubleArray> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
inline void set(int index, double value);
inline void set_the_hole(int index);
@@ -4399,8 +4397,7 @@ class ExternalUint8ClampedArray: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined and clamps the converted value between 0 and 255.
- static void SetValue(Handle<ExternalUint8ClampedArray> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalUint8ClampedArray)
@@ -4422,8 +4419,7 @@ class ExternalInt8Array: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<ExternalInt8Array> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalInt8Array)
@@ -4445,8 +4441,7 @@ class ExternalUint8Array: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<ExternalUint8Array> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalUint8Array)
@@ -4468,8 +4463,7 @@ class ExternalInt16Array: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<ExternalInt16Array> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalInt16Array)
@@ -4492,8 +4486,7 @@ class ExternalUint16Array: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<ExternalUint16Array> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalUint16Array)
@@ -4515,8 +4508,7 @@ class ExternalInt32Array: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<ExternalInt32Array> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalInt32Array)
@@ -4539,8 +4531,7 @@ class ExternalUint32Array: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<ExternalUint32Array> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalUint32Array)
@@ -4563,8 +4554,7 @@ class ExternalFloat32Array: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<ExternalFloat32Array> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalFloat32Array)
@@ -4587,8 +4577,7 @@ class ExternalFloat64Array: public ExternalArray {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<ExternalFloat64Array> array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_CAST(ExternalFloat64Array)
@@ -4656,8 +4645,7 @@ class FixedTypedArray: public FixedTypedArrayBase {
// This accessor applies the correct conversion from Smi, HeapNumber
// and undefined.
- static void SetValue(Handle<FixedTypedArray<Traits> > array, uint32_t index,
- Handle<Object> value);
+ void SetValue(uint32_t index, Object* value);
DECLARE_PRINTER(FixedTypedArray)
DECLARE_VERIFIER(FixedTypedArray)
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698