Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1196483003: Disable cfi-unrelated-cast sanitizer in OpParameter function. (Closed)

Created:
5 years, 6 months ago by pcc1
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable cfi-unrelated-cast sanitizer in OpParameter function. This function deliberately casts to an unrelated type. This is forbidden under the cfi-unrelated-cast policy, but it is unclear how to fix the underlying problem. This change at least unblocks things. BUG=v8:3809 R=svenpanne@chromium.org,mstarzinger@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/base/macros.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/operator.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pcc1
5 years, 6 months ago (2015-06-18 22:49:25 UTC) #1
Sven Panne
Hmmm, I'm not sure if this is the right way to proceed: With this CL, ...
5 years, 6 months ago (2015-06-19 09:06:22 UTC) #3
Benedikt Meurer
5 years, 6 months ago (2015-06-19 11:28:13 UTC) #4
I think we should fix the bugs instead of trying to silence some warnings. I've
uploaded a fix for the issue, see https://codereview.chromium.org/1196623002

Powered by Google App Engine
This is Rietveld 408576698