Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1196623002: [ubsan] Fix HeapObjectMatcher to avoid invalid casts. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ubsan] Fix HeapObjectMatcher to avoid invalid casts. BUG=v8:3809 LOG=n R=svenpanne@chromium.org Committed: https://crrev.com/1021ed85cb45e4eb879ed253e0451137e2aeaecc Cr-Commit-Position: refs/heads/master@{#29147}

Patch Set 1 #

Patch Set 2 : Fix failing assert. #

Patch Set 3 : REBASE #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -50 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator-reducer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A src/compiler/control-reducer.cc View 1 2 1 chunk +327 lines, -0 lines 1 comment Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-context-specialization.h View 2 chunks +16 lines, -6 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 6 chunks +21 lines, -17 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-19 11:27:06 UTC) #1
Benedikt Meurer
Hey Sven, The UBSan fix. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-19 11:28:35 UTC) #2
Sven Panne
lgtm
5 years, 6 months ago (2015-06-19 12:12:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196623002/40001
5 years, 6 months ago (2015-06-19 12:12:54 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-19 12:49:05 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1021ed85cb45e4eb879ed253e0451137e2aeaecc Cr-Commit-Position: refs/heads/master@{#29147}
5 years, 6 months ago (2015-06-19 12:49:26 UTC) #7
conradw
5 years, 6 months ago (2015-06-19 21:38:53 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1196623002/diff/40001/src/compiler/control-re...
File src/compiler/control-reducer.cc (right):

https://codereview.chromium.org/1196623002/diff/40001/src/compiler/control-re...
src/compiler/control-reducer.cc:7: #include "src/compiler/control-reducer.h"
I think this file was reintroduced by mistake with the rebase. It and this
header were removed in https://codereview.chromium.org/1193833002/

This seems to break building with ninja, at least on my machine.

Powered by Google App Engine
This is Rietveld 408576698