Move SetCursorLocation bypass code.

Move SetCursorLocation bypass code.

Current Chrome does not emit SetCursorLocation message to ibus-daemon because both candidate window and input context is in same process.
It was achieved by injecting IBusClient into ui::InputMethodIBus, but we are now able to bypass them only in chromeos/ directory.
With this refactoring, we can remove ui::internal::IBusClient, IBusChromeOSClientImpl and their injection code.

The concept of this refactoring is...
1) ui::InputMethodIBus should communicate with only chromeos::IBus*.
  Do not bypass chromeos::IBus* even if bypassing ibus-daemon.
2) chrome/browser/chromeos/input_method should communicate with only chromeos::IBus*
  current code handles SetCursorLocation as special case, but I think it shouldn't consider where the event is come from.
  Such special logic should be in chromeos/.

With this patch, we can remove IBusUiController.

BUG=None
TEST=Manually done on lumpy.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179644

[Seigo Nonaka, 2013-01-16 06:28:24]

Sorry for huge patch, but could you take a look?

[satorux1, 2013-01-17 20:46:18]

Can you split this patch? For instance, I guess you can create a separate patch
for changes in chromeos/dbus/ibus.

[Seigo Nonaka, 2013-01-21 04:53:34]

Done(split this into two, the other part is 
https://codereview.chromium.org/12017010/).

PTAL?

On 2013/01/17 20:46:18, satorux1 wrote:
> Can you split this patch? For instance, I guess you can create a separate
patch
> for changes in chromeos/dbus/ibus.

[satorux1, 2013-01-29 05:16:08]

LGTM with nits

https://codereview.chromium.org/11956008/diff/22002/chrome/browser/chromeos/i...
File chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
(right):

https://codereview.chromium.org/11956008/diff/22002/chrome/browser/chromeos/i...
chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc:146:
cursor_location.height));
Cannot we do something like:

candidate_window_->set_cursor_location(cursor_location.ToGfxRect());

https://codereview.chromium.org/11956008/diff/22002/ui/base/ime/input_method_...
File ui/base/ime/input_method_ibus.cc (right):

https://codereview.chromium.org/11956008/diff/22002/ui/base/ime/input_method_...
ui/base/ime/input_method_ibus.cc:222: rect.height());
maybe: 

chromeos::ibus::Rect rect_ibus = chromeos::ibus::Rect::FromGfxRect(rect);

[Seigo Nonaka, 2013-01-30 06:00:07]

Thank you for your review

https://codereview.chromium.org/11956008/diff/22002/chrome/browser/chromeos/i...
File chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
(right):

https://codereview.chromium.org/11956008/diff/22002/chrome/browser/chromeos/i...
chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc:146:
cursor_location.height));
We can't add member function into ibus::Rect structure because ui reference into
chromeos is banned.
I introduced IBusRectToGfxRect function locally instead.
On 2013/01/29 05:16:08, satorux1 wrote:
> Cannot we do something like:
> 
> candidate_window_->set_cursor_location(cursor_location.ToGfxRect());

https://codereview.chromium.org/11956008/diff/22002/ui/base/ime/input_method_...
File ui/base/ime/input_method_ibus.cc (right):

https://codereview.chromium.org/11956008/diff/22002/ui/base/ime/input_method_...
ui/base/ime/input_method_ibus.cc:222: rect.height());
We can't introduce FromGfxRect function into chromeos::ibus::Rect because ui
dependency is banned in chromeos.
I introduce GfxRectToIBusRect function locally instead.
On 2013/01/29 05:16:08, satorux1 wrote:
> maybe: 
> 
> chromeos::ibus::Rect rect_ibus = chromeos::ibus::Rect::FromGfxRect(rect);

[commit-bot: I haz the power, 2013-01-30 06:02:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11956008/40031

[commit-bot: I haz the power, 2013-01-30 08:17:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11956008/32020

[commit-bot: I haz the power, 2013-01-30 16:39:15]

Change committed as 179644