Move SetCursorLocation bypass code.

chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/candidate_window_controller_impl.h"
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 106 matching lines @@
 void CandidateWindowControllerImpl::OnHideLookupTable() {
   candidate_window_->HideLookupTable();
   infolist_window_->Hide();
 }
 
 void CandidateWindowControllerImpl::OnHidePreeditText() {
   candidate_window_->HidePreeditText();
 }
 
 void CandidateWindowControllerImpl::OnSetCursorLocation(
-    const gfx::Rect& cursor_location,
-    const gfx::Rect& composition_head) {
+    const ibus::Rect& cursor_location,
+    const ibus::Rect& composition_head) {
   // A workaround for http://crosbug.com/6460. We should ignore very short Y
   // move to prevent the window from shaking up and down.
   const int kKeepPositionThreshold = 2;  // px
   const gfx::Rect& last_location =
       candidate_window_->cursor_location();
-  const int delta_y = abs(last_location.y() - cursor_location.y());
-  if ((last_location.x() == cursor_location.x()) &&
+  const int delta_y = abs(last_location.y() - cursor_location.y);
+  if ((last_location.x() == cursor_location.x) &&
       (delta_y <= kKeepPositionThreshold)) {
     DVLOG(1) << "Ignored set_cursor_location signal to prevent window shake";
     return;
   }
 
   // Remember the cursor location.
-  candidate_window_->set_cursor_location(cursor_location);
-  candidate_window_->set_composition_head_location(composition_head);
+  candidate_window_->set_cursor_location(
+      gfx::Rect(cursor_location.x,
+                cursor_location.y,
+                cursor_location.width,
+                cursor_location.height));

[satorux1, 2013/01/29 05:16:08]

Cannot we do something like:

candidate_window_->set_cursor_location(cursor_location.ToGfxRect());

[Seigo Nonaka, 2013/01/30 06:00:07]

We can't add member function into ibus::Rect structure because ui reference into
chromeos is banned.
I introduced IBusRectToGfxRect function locally instead.
On 2013/01/29 05:16:08, satorux1 wrote:

+  candidate_window_->set_composition_head_location(
+      gfx::Rect(composition_head.x,
+                composition_head.y,
+                composition_head.width,
+                composition_head.height));
   // Move the window per the cursor location.
   candidate_window_->ResizeAndMoveParentFrame();
   UpdateInfolistBounds();
 }
 
 void CandidateWindowControllerImpl::OnUpdateAuxiliaryText(
     const std::string& utf8_text,
     bool visible) {
   // If it's not visible, hide the auxiliary text and return.
   if (!visible) {
@@ skipping 192 matching lines @@
 
   if (candidate_window_rect.y() + infolist_window_size.height() >
       screen_rect.bottom())
     result.set_y(screen_rect.bottom() - infolist_window_size.height());
 
   return result;
 }
 
 }  // namespace input_method
 }  // namespace chromeos