Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/chromeos/input_method/ibus_ui_controller.h

Issue 11956008: Move SetCursorLocation bypass code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unittests: add TextInputTestSupport initialzation Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/ibus_ui_controller.h
diff --git a/chrome/browser/chromeos/input_method/ibus_ui_controller.h b/chrome/browser/chromeos/input_method/ibus_ui_controller.h
index d01ce3cee1c03e4792ffd3f34642605065dadb58..a46209ba458e2b2619c8586f1e0d760e254dfe7e 100644
--- a/chrome/browser/chromeos/input_method/ibus_ui_controller.h
+++ b/chrome/browser/chromeos/input_method/ibus_ui_controller.h
@@ -45,8 +45,8 @@ class IBusUiController : public ibus::IBusPanelCandidateWindowHandlerInterface {
virtual void OnHidePreeditText() = 0;
// Called when the cursor location is set.
- virtual void OnSetCursorLocation(const gfx::Rect& cusor_location,
- const gfx::Rect& composition_head) = 0;
+ virtual void OnSetCursorLocation(const ibus::Rect& cusor_location,
+ const ibus::Rect& composition_head) = 0;
// Called when the auxiliary text is updated.
virtual void OnUpdateAuxiliaryText(const std::string& text,
@@ -99,12 +99,6 @@ class IBusUiController : public ibus::IBusPanelCandidateWindowHandlerInterface {
// sent to the ibus-daemon
void NotifyPageDown();
- // Handles cursor location update event. This is originate from
- // SetCursorLocation method call, but we can bypass it on Chrome OS because
- // candidate window is integrated with Chrome.
- void SetCursorLocation(const gfx::Rect& cursor_location,
- const gfx::Rect& composition_head);
-
private:
// IBusPanelHandlerInterface overrides.
virtual void UpdateLookupTable(const ibus::IBusLookupTable& table,
@@ -116,6 +110,8 @@ class IBusUiController : public ibus::IBusPanelCandidateWindowHandlerInterface {
virtual void UpdatePreeditText(const std::string& text, uint32 cursor_pos,
bool visible) OVERRIDE;
virtual void HidePreeditText() OVERRIDE;
+ virtual void SetCursorLocation(const ibus::Rect& cursor_location,
+ const ibus::Rect& composition_head) OVERRIDE;
ObserverList<Observer> observers_;

Powered by Google App Engine
This is Rietveld 408576698