Issue 119493004: [Password Autofill] Trigger onChange events in JavaScript when autofilling passwords.

Issue 119493004: [Password Autofill] Trigger onChange events in JavaScript when autofilling passwords. (Closed)

Created:
7 years ago by Ilya Sherman

Modified:
6 years, 11 months ago

Reviewers:
Garrett Casto

CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Password Autofill] Trigger onChange events in JavaScript when autofilling passwords. BUG=307308 TEST=browser_tests R=gcasto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244125

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Temporarily disable part of the test while waiting on http://crbug.com/333144 to be fixed. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -27 lines)			Patch
M	chrome/renderer/autofill/password_autofill_agent_browsertest.cc	View	1 2	9 chunks	+127 lines, -22 lines	0 comments	Download
M	components/autofill/content/renderer/autofill_agent.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/autofill/content/renderer/password_autofill_agent.cc	View	1	4 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

Note: this depends on https://codereview.chromium.org/119493003 for the tests to pass.

7 years ago (2013-12-19 22:46:18 UTC) #1

Garrett Casto

lgtm https://codereview.chromium.org/119493004/diff/1/chrome/renderer/autofill/password_autofill_agent_browsertest.cc File chrome/renderer/autofill/password_autofill_agent_browsertest.cc (right): https://codereview.chromium.org/119493004/diff/1/chrome/renderer/autofill/password_autofill_agent_browsertest.cc#newcode858 chrome/renderer/autofill/password_autofill_agent_browsertest.cc:858: Extra space.

6 years, 11 months ago (2014-01-09 19:14:32 UTC) #2

Ilya Sherman

https://codereview.chromium.org/119493004/diff/1/chrome/renderer/autofill/password_autofill_agent_browsertest.cc File chrome/renderer/autofill/password_autofill_agent_browsertest.cc (right): https://codereview.chromium.org/119493004/diff/1/chrome/renderer/autofill/password_autofill_agent_browsertest.cc#newcode858 chrome/renderer/autofill/password_autofill_agent_browsertest.cc:858: On 2014/01/09 19:14:32, Garrett Casto wrote: > Extra space. ...

6 years, 11 months ago (2014-01-10 06:32:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/119493004/120001

6 years, 11 months ago (2014-01-10 06:32:50 UTC) #4

Message was sent while issue was closed.

Change committed as 244125

Expand Messages | Collapse Messages