Issue 119493003: Remove a no-longer needed user gesture from WebFrameImpl::executeScriptAndReturnValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119493003: Remove a no-longer needed user gesture from WebFrameImpl::executeScriptAndReturnValue() (Closed)

Created:
7 years ago by Ilya Sherman

Modified:
6 years, 8 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove a no-longer needed user gesture from WebFrameImpl::executeScriptAndReturnValue() This user gesture was previously added to support a test suite that is now obsolete. BUG=86397, 333144 TEST=none R=abarth@chromium.org

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	Source/web/WebFrameImpl.cpp	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

7 years ago (2013-12-20 04:36:10 UTC) #3

On 2013/12/20 04:34:15, abarth wrote:
> LGTM!

Note: Trybot results tell me I might actually have been overly optimistic on
this change, but I'm still going to try to find a better way to get those tests
running, with the intent of being able to safely land this CL :)

Expand Messages | Collapse Messages