[Password Autofill] Trigger onChange events in JavaScript when autofilling passwords.

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 653 matching lines @@
 
   // If we can't modify the password, don't try to set the username
   if (!IsElementAutocompletable(password_element))
     return;
 
   // Try to set the username to the preferred name, but only if the field
   // can be set and isn't prefilled.
   if (IsElementAutocompletable(username_element) &&
       username_element.value().isEmpty()) {
     // TODO(tkent): Check maxlength and pattern.
-    username_element.setValue(fill_data.basic_data.fields[0].value);
+    username_element.setValue(fill_data.basic_data.fields[0].value, true);
   }
 
   // Fill if we have an exact match for the username. Note that this sets
   // username to autofilled.
   FillUserNameAndPassword(&username_element, &password_element, fill_data,
                           true /* exact_username_match */,
                           false /* set_selection */);
 }
 
 bool PasswordAutofillAgent::FillUserNameAndPassword(
@@ skipping 50 matching lines @@
   // TODO(tkent): Check maxlength and pattern for both username and password
   // fields.
 
   // Don't fill username if password can't be set.
   if (!IsElementAutocompletable(*password_element)) {
     return false;
   }
 
   // Input matches the username, fill in required values.
   if (IsElementAutocompletable(*username_element)) {
-    username_element->setValue(username);
+    username_element->setValue(username, true);
     SetElementAutofilled(username_element, true);
 
     if (set_selection) {
       username_element->setSelectionRange(current_username.length(),
                                           username.length());
     }
   } else if (current_username != username) {
     // If the username can't be filled and it doesn't match a saved password
     // as is, don't autofill a password.
     return false;
   }
 
   // If a user gesture has not occurred, we setup a handler to listen for the
   // next user gesture, at which point we then fill in the password. This is to
   // make sure that we do not fill in the DOM with a password until we believe
   // the user is intentionally interacting with the page.
   if (!user_gesture_occurred_) {
     gesture_handler_->addElement(*password_element);
     password_element->setSuggestedValue(password);
   } else {
-    password_element->setValue(password);
+    password_element->setValue(password, true);
   }
-  SetElementAutofilled(password_element, true);
+  // Note: Don't call SetElementAutofilled() here, as that dispatches an
+  // onChange event in JavaScript, which is not appropriate for the password
+  // element if a user gesture has not yet occured.
+  password_element->setAutofilled(true);
   return true;
 }
 
 void PasswordAutofillAgent::PerformInlineAutocomplete(
     const blink::WebInputElement& username_input,
     const blink::WebInputElement& password_input,
     const PasswordFormFillData& fill_data) {
   DCHECK(!fill_data.wait_for_username);
 
   // We need non-const versions of the username and password inputs.
@@ skipping 57 matching lines @@
   *found_password = iter->second;
   return true;
 }
 
 void PasswordAutofillAgent::AutofillWebUserGestureHandler::onGesture() {
   agent_->set_user_gesture_occurred(true);
 
   std::vector<blink::WebInputElement>::iterator iter;
   for (iter = elements_.begin(); iter != elements_.end(); ++iter) {
     if (!iter->isNull() && !iter->suggestedValue().isNull())
-      iter->setValue(iter->suggestedValue());
+      iter->setValue(iter->suggestedValue(), true);
   }
 
   elements_.clear();
 }
 
 PasswordAutofillAgent::AutofillWebUserGestureHandler::
     AutofillWebUserGestureHandler(PasswordAutofillAgent* agent)
     : agent_(agent) {}
 
 PasswordAutofillAgent::AutofillWebUserGestureHandler::
     ~AutofillWebUserGestureHandler() {}
 
 }  // namespace autofill