Source/core/css/parser/CSSPropertyParser.cpp - Issue 1193753002: Serialize zIndex as an integer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1193753002: Serialize zIndex as an integer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix regression and add test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index e1f79d30d75d0cf1591f02e91a98c9279f57ece4..097a7c9a2507e84fdd7d463ea2528d3003d1cfe4 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -860,10 +860,12 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import

break;

case CSSPropertyZIndex: // auto | <integer> | inherit

- if (id == CSSValueAuto)

+ if (id == CSSValueAuto) {

validPrimitive = true;

- else

- validPrimitive = validUnit(value, FInteger);

+ } else if (validUnit(value, FInteger)) {

+ addProperty(propId, cssValuePool().createValue(value->fValue, CSSPrimitiveValue::CSS_INTEGER), important);

+ return true;

+ }

break;

case CSSPropertyLineHeight: