Source/core/css/CSSCalculationValue.cpp - Issue 1193753002: Serialize zIndex as an integer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.cpp

Issue 1193753002: Serialize zIndex as an integer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix regression and add test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSCalculationValue.cpp

diff --git a/Source/core/css/CSSCalculationValue.cpp b/Source/core/css/CSSCalculationValue.cpp

index 998fba4d322d019fc2069e1f42690de038ab1169..a3707efab0d86f90a6ef9c1e5362eea45611ac11 100644

--- a/Source/core/css/CSSCalculationValue.cpp

+++ b/Source/core/css/CSSCalculationValue.cpp

@@ -51,6 +51,7 @@ static CalculationCategory unitCategory(CSSPrimitiveValue::UnitType type)

{

switch (type) {

case CSSPrimitiveValue::CSS_NUMBER:

+ case CSSPrimitiveValue::CSS_INTEGER:

return CalcNumber;

case CSSPrimitiveValue::CSS_PERCENTAGE:

return CalcPercent;

@@ -135,6 +136,7 @@ static bool hasDoubleValue(CSSPrimitiveValue::UnitType type)

case CSSPrimitiveValue::CSS_PROPERTY_ID:

case CSSPrimitiveValue::CSS_VALUE_ID:

case CSSPrimitiveValue::CSS_QEM:

+ case CSSPrimitiveValue::CSS_INTEGER:

Timothy Loh 2015/06/29 04:29:50 probably should be true? maybe see if you can make

return false;

};

ASSERT_NOT_REACHED();