Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 1193753002: Serialize zIndex as an integer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1193753002: Serialize zIndex as an integer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix regression and add test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/Source/core/css/ComputedStyleCSSValueMapping.cpp b/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 4c8e0e406815643bab17c6902817f83b2cf36407..e681f202a9f8bae2e9453d8552e7ef27106cd993 100644

--- a/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -2079,7 +2079,7 @@ PassRefPtrWillBeRawPtr<CSSValue> ComputedStyleCSSValueMapping::get(CSSPropertyID

case CSSPropertyZIndex:

if (style.hasAutoZIndex())

return cssValuePool().createIdentifierValue(CSSValueAuto);

- return cssValuePool().createValue(style.zIndex(), CSSPrimitiveValue::CSS_NUMBER);

+ return cssValuePool().createValue(style.zIndex(), CSSPrimitiveValue::CSS_INTEGER);

case CSSPropertyZoom:

return cssValuePool().createValue(style.zoom(), CSSPrimitiveValue::CSS_NUMBER);

case CSSPropertyBoxSizing: