Vector ICs: Additional Turbofan support

Vector ICs: Additional Turbofan support

Lowering of stores need the vector and slot if --vector-stores is true.

BUG=

Committed: https://crrev.com/e9445d7d48b3dc5463d28a023c548a51ef1837ae
Cr-Commit-Position: refs/heads/master@{#29219}

[mvstanton, 2015-06-22 06:34:24]

mvstanton@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[mvstanton, 2015-06-22 06:34:24]

Hi Michael,
PTAL, thanks :)
--Michael

[Michael Starzinger, 2015-06-22 08:40:55]

https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:516: int inputs = FLAG_vector_stores ? 3 : 2;
Can we make the number of inputs always be 3 for this operator? If
FLAG_vector_stores are off we can just pass undefined to the operator and remove
it in generic lowering. But having different number of inputs depending on a
flag seems brittle.

https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:528: int inputs = FLAG_vector_stores ? 4 : 3;
Likewise for always having 4 inputs.

[mvstanton, 2015-06-23 08:27:05]

Hi Michael, thanks for the good comments. I also fixed a typo from the previous
CL.
Best,
--Michael

https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:516: int inputs = FLAG_vector_stores ? 3 : 2;
On 2015/06/22 08:40:55, Michael Starzinger wrote:
> Can we make the number of inputs always be 3 for this operator? If
> FLAG_vector_stores are off we can just pass undefined to the operator and
remove
> it in generic lowering. But having different number of inputs depending on a
> flag seems brittle.

Good idea. In fact, we can just pass the feedback vector too. Done.

https://codereview.chromium.org/1193313002/diff/1/src/compiler/js-operator.cc...
src/compiler/js-operator.cc:528: int inputs = FLAG_vector_stores ? 4 : 3;
On 2015/06/22 08:40:55, Michael Starzinger wrote:
> Likewise for always having 4 inputs.

Done.

[Michael Starzinger, 2015-06-23 08:31:14]

LGTM. I like it. You will need to rebase onto my last CL, sorry about that.

https://codereview.chromium.org/1193313002/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1193313002/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:1836:
expr->SlotForHomeObject(it->second->setter, &store_slot_index));
Nice catch! :)

[mvstanton, 2015-06-23 08:38:27]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-06-23 08:38:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1193313002/#ps40001
(title: "REBASE.")

[commit-bot: I haz the power, 2015-06-23 08:38:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1193313002/40001

[commit-bot: I haz the power, 2015-06-23 09:09:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-23 09:09:26]

Patchset 3 (id:??) landed as
https://crrev.com/e9445d7d48b3dc5463d28a023c548a51ef1837ae
Cr-Commit-Position: refs/heads/master@{#29219}