Vector ICs: Additional Turbofan support

src/compiler/js-operator.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-operator.h"
 
 #include <limits>
 
 #include "src/base/lazy-instance.h"
 #include "src/compiler/opcodes.h"
@@ skipping 495 matching lines @@
       "JSLoadProperty",                                    // name
       3, 1, 1, 1, 1, 2,                                    // counts
       parameters);                                         // parameter
 }
 
 
 const Operator* JSOperatorBuilder::StoreNamed(
     LanguageMode language_mode, const Unique<Name>& name,
     const ResolvedFeedbackSlot& feedback) {
   StoreNamedParameters parameters(language_mode, feedback, name);
+  int inputs = FLAG_vector_stores ? 3 : 2;

[Michael Starzinger, 2015/06/22 08:40:55]

Can we make the number of inputs always be 3 for this operator? If
FLAG_vector_stores are off we can just pass undefined to the operator and remove
it in generic lowering. But having different number of inputs depending on a
flag seems brittle.

[mvstanton, 2015/06/23 08:27:05]

Good idea. In fact, we can just pass the feedback vector too. Done.

   return new (zone()) Operator1<StoreNamedParameters>(   // --
       IrOpcode::kJSStoreNamed, Operator::kNoProperties,  // opcode
       "JSStoreNamed",                                    // name
-      2, 1, 1, 0, 1, 2,                                  // counts
+      inputs, 1, 1, 0, 1, 2,                             // counts
       parameters);                                       // parameter
 }
 
 
 const Operator* JSOperatorBuilder::StoreProperty(
     LanguageMode language_mode, const ResolvedFeedbackSlot& feedback) {
   StorePropertyParameters parameters(language_mode, feedback);
+  int inputs = FLAG_vector_stores ? 4 : 3;

[Michael Starzinger, 2015/06/22 08:40:55]

Likewise for always having 4 inputs.

[mvstanton, 2015/06/23 08:27:05]

Done.

   return new (zone()) Operator1<StorePropertyParameters>(   // --
       IrOpcode::kJSStoreProperty, Operator::kNoProperties,  // opcode
       "JSStoreProperty",                                    // name
-      3, 1, 1, 0, 1, 2,                                     // counts
+      inputs, 1, 1, 0, 1, 2,                                // counts
       parameters);                                          // parameter
 }
 
 
 const Operator* JSOperatorBuilder::DeleteProperty(LanguageMode language_mode) {
   return new (zone()) Operator1<LanguageMode>(               // --
       IrOpcode::kJSDeleteProperty, Operator::kNoProperties,  // opcode
       "JSDeleteProperty",                                    // name
       2, 1, 1, 1, 1, 2,                                      // counts
       language_mode);                                        // parameter
@@ skipping 82 matching lines @@
   return new (zone()) Operator1<Unique<String>>(                 // --
       IrOpcode::kJSCreateCatchContext, Operator::kNoProperties,  // opcode
       "JSCreateCatchContext",                                    // name
       2, 1, 1, 1, 1, 2,                                          // counts
       name);                                                     // parameter
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8