Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: content/shell/shell_content_browser_client.cc

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/shell_content_browser_client.cc
diff --git a/content/shell/shell_content_browser_client.cc b/content/shell/shell_content_browser_client.cc
index 22e594960e7872c21a6b2b00546ce1e4c2981a19..d6f241b3e55a2b4a95d57857506a457688483a1c 100644
--- a/content/shell/shell_content_browser_client.cc
+++ b/content/shell/shell_content_browser_client.cc
@@ -9,6 +9,7 @@
#include "base/path_service.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/resource_dispatcher_host.h"
+#include "content/public/common/url_constants.h"
#include "content/shell/geolocation/shell_access_token_store.h"
#include "content/shell/shell.h"
#include "content/shell/shell_browser_context.h"
@@ -79,6 +80,15 @@ void ShellContentBrowserClient::RenderProcessHostCreated(
host->Send(new ShellViewMsg_SetWebKitSourceDir(webkit_source_dir_));
}
+bool ShellContentBrowserClient::IsHandledURL(const GURL& url) {
erikwright (departed) 2013/01/21 16:20:13 At some point I'd like to understand why we can't
pauljensen 2013/01/22 14:25:03 I agree it's ripe for simplification but in anothe
mmenke 2013/01/22 16:52:47 I'm pretty sure the ContentBrowserClient lives on
pauljensen 2013/01/23 21:43:33 I debugged a little and ContentBrowserClient::IsHa
+ if (!url.is_valid())
+ return false;
+ // Keep in sync with ProtocolHandlers added by
+ // ShellURLRequestContextGetter::GetURLRequestContext().
+ return url.scheme() == chrome::kDataScheme ||
+ url.scheme() == chrome::kFileScheme;
+}
+
void ShellContentBrowserClient::AppendExtraCommandLineSwitches(
CommandLine* command_line, int child_process_id) {
if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kDumpRenderTree))

Powered by Google App Engine
This is Rietveld 408576698