Removed static factories for data, ftp, file, and about jobs.

content/shell/shell_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/shell_content_browser_client.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/resource_dispatcher_host.h"
+#include "content/public/common/url_constants.h"
 #include "content/shell/geolocation/shell_access_token_store.h"
 #include "content/shell/shell.h"
 #include "content/shell/shell_browser_context.h"
 #include "content/shell/shell_browser_main_parts.h"
 #include "content/shell/shell_devtools_delegate.h"
 #include "content/shell/shell_messages.h"
 #include "content/shell/shell_resource_dispatcher_host_delegate.h"
 #include "content/shell/shell_switches.h"
 #include "content/shell/shell_web_contents_view_delegate_creator.h"
 #include "content/shell/webkit_test_controller.h"
@@ skipping 50 matching lines @@
   return shell_browser_main_parts_;
 }
 
 void ShellContentBrowserClient::RenderProcessHostCreated(
     RenderProcessHost* host) {
   if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kDumpRenderTree))
     return;
   host->Send(new ShellViewMsg_SetWebKitSourceDir(webkit_source_dir_));
 }
 
+bool ShellContentBrowserClient::IsHandledURL(const GURL& url) {

[erikwright (departed), 2013/01/21 16:20:13]

At some point I'd like to understand why we can't just ask the
URLRequestJobFactory instance this question.

I don't suggest changing it in this CL, but I think this is ripe for
simplification.

[pauljensen, 2013/01/22 14:25:03]

I agree it's ripe for simplification but in another CL.  I wonder if it's called
on the IO thread.  We may also need to add a BrowserContext* argument to
ContentBrowserClient::IsHandledURL().

[mmenke, 2013/01/22 16:52:47]

I'm pretty sure the ContentBrowserClient lives on the UI thread.

[pauljensen, 2013/01/23 21:43:33]

I debugged a little and ContentBrowserClient::IsHandledURL() seems to be called
on both the IO and UI threads which is one reason we can't make this simply call
URLRequestJobFactory.

+  if (!url.is_valid())
+    return false;
+  // Keep in sync with ProtocolHandlers added by
+  // ShellURLRequestContextGetter::GetURLRequestContext().
+  return url.scheme() == chrome::kDataScheme ||
+      url.scheme() == chrome::kFileScheme;
+}
+
 void ShellContentBrowserClient::AppendExtraCommandLineSwitches(
     CommandLine* command_line, int child_process_id) {
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kDumpRenderTree))
     command_line->AppendSwitch(switches::kDumpRenderTree);
 }
 
 void ShellContentBrowserClient::OverrideWebkitPrefs(
     RenderViewHost* render_view_host,
     const GURL& url,
     webkit_glue::WebPreferences* prefs) {
@@ skipping 66 matching lines @@
 ShellBrowserContext*
     ShellContentBrowserClient::off_the_record_browser_context() {
   return shell_browser_main_parts_->off_the_record_browser_context();
 }
 
 AccessTokenStore* ShellContentBrowserClient::CreateAccessTokenStore() {
   return new ShellAccessTokenStore(browser_context()->GetRequestContext());
 }
 
 }  // namespace content