Removed static factories for data, ftp, file, and about jobs.

net/url_request/ftp_protocol_handler.h

Index: net/url_request/ftp_protocol_handler.h
diff --git a/net/url_request/ftp_protocol_handler.h b/net/url_request/ftp_protocol_handler.h
index 871f42205ebc434335f51d2ed784e1514a48763a..52aea7cf07f2fe7334bfa5ec68982918b10f6a70 100644
--- a/net/url_request/ftp_protocol_handler.h
+++ b/net/url_request/ftp_protocol_handler.h
@@ -7,11 +7,11 @@
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "net/ftp/ftp_auth_cache.h"
 #include "net/url_request/url_request_job_factory.h"
 
 namespace net {
 
-class FtpAuthCache;
 class FtpTransactionFactory;
 class NetworkDelegate;
 class URLRequestJob;
@@ -20,14 +20,13 @@ class URLRequestJob;
 class NET_EXPORT FtpProtocolHandler :
     public URLRequestJobFactory::ProtocolHandler {
  public:
-  FtpProtocolHandler(FtpTransactionFactory* ftp_transaction_factory,
-                     FtpAuthCache* ftp_auth_cache);
+  explicit FtpProtocolHandler(FtpTransactionFactory* ftp_transaction_factory);
   virtual URLRequestJob* MaybeCreateJob(
       URLRequest* request, NetworkDelegate* network_delegate) const OVERRIDE;

[erikwright (departed), 2013/01/21 16:20:13]

I think an argument could be made that MaybeCreateJob shouldn't be const.

I wouldn't suggest changing it now, but this CL highlights the fact that a job
factory can change by creating jobs, as the job that is created now can
potentially change the behaviour of a job that is created later.

[pauljensen, 2013/01/22 14:25:03]

Ya, it was annoying here too:
https://codereview.chromium.org/11308362/diff/70001/content/browser/storage_p...

 
  private:
   FtpTransactionFactory* ftp_transaction_factory_;
-  FtpAuthCache* ftp_auth_cache_;
+  mutable FtpAuthCache ftp_auth_cache_;
 
   DISALLOW_COPY_AND_ASSIGN(FtpProtocolHandler);
 };