Issue 1192753003: Merge 196373 "binding: Supports static operations/attrs returnin..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1192753003: Merge 196373 "binding: Supports static operations/attrs returnin..." (Closed)

Created:
5 years, 6 months ago by Yuki

Modified:
5 years, 6 months ago

Reviewers:
haraken, Yuki

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2357/

Project:
blink

Visibility:
Public.

Merge 196373 "binding: Supports static operations/attrs returnin..." > binding: Supports static operations/attrs returning non-primitive types. > > Correctly supports static operations/attributes which return non-primitive types, so that the returned object is associated with the caller's context, not associated with |this| which can be faked. > > BUG=494640 > > Review URL: https://codereview.chromium.org/1163893002 TBR=yukishiino@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197431

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -3 lines)			Patch
A +	LayoutTests/http/tests/security/cross-frame-access-static-operation-return-wrapper.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/http/tests/security/cross-frame-access-static-operation-return-wrapper-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/bindings/core/v8/V8Binding.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/bindings/scripts/v8_attributes.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/v8_methods.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/v8_types.py	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	Source/bindings/tests/idls/core/TestInterface.idl	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/results/core/V8TestInterface.cpp	View	4 chunks	+49 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

LGTM