Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: Source/bindings/core/v8/V8Binding.h

Issue 1192753003: Merge 196373 "binding: Supports static operations/attrs returnin..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/2357/
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8Binding.h
===================================================================
--- Source/bindings/core/v8/V8Binding.h (revision 197430)
+++ Source/bindings/core/v8/V8Binding.h (working copy)
@@ -191,7 +191,7 @@
}
template<typename CallbackInfo>
-inline void v8SetReturnValue(const CallbackInfo& callbackInfo, ScriptWrappable* impl)
+inline void v8SetReturnValue(const CallbackInfo& callbackInfo, ScriptWrappable* impl, v8::Local<v8::Object> creationContext)
{
if (UNLIKELY(!impl)) {
v8SetReturnValueNull(callbackInfo);
@@ -199,11 +199,17 @@
}
if (DOMDataStore::setReturnValue(callbackInfo.GetReturnValue(), impl))
return;
- v8::Handle<v8::Object> wrapper = impl->wrap(callbackInfo.Holder(), callbackInfo.GetIsolate());
+ v8::Handle<v8::Object> wrapper = impl->wrap(creationContext, callbackInfo.GetIsolate());
v8SetReturnValue(callbackInfo, wrapper);
}
template<typename CallbackInfo>
+inline void v8SetReturnValue(const CallbackInfo& callbackInfo, ScriptWrappable* impl)
+{
+ v8SetReturnValue(callbackInfo, impl, callbackInfo.Holder());
+}
+
+template<typename CallbackInfo>
inline void v8SetReturnValue(const CallbackInfo& callbackInfo, Node* impl)
{
if (UNLIKELY(!impl)) {

Powered by Google App Engine
This is Rietveld 408576698