Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1163893002: binding: Supports static operations/attrs returning non-primitive types. (Closed)

Created:
5 years, 6 months ago by Yuki
Modified:
5 years, 6 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

binding: Supports static operations/attrs returning non-primitive types. Correctly supports static operations/attributes which return non-primitive types, so that the returned object is associated with the caller's context, not associated with |this| which can be faked. BUG=494640 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196373

Patch Set 1 #

Patch Set 2 : Added a layout test. #

Patch Set 3 : Fixed the layout test. #

Patch Set 4 : Added a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -5 lines) Patch
A LayoutTests/http/tests/security/cross-frame-access-static-operation-return-wrapper.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/cross-frame-access-static-operation-return-wrapper-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 2 chunks +8 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/core/TestInterface.idl View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 4 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Could you guys review this CL?
5 years, 6 months ago (2015-06-02 12:42:06 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-02 13:19:21 UTC) #3
bashi
LGTM
5 years, 6 months ago (2015-06-03 03:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163893002/60001
5 years, 6 months ago (2015-06-03 04:35:35 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 06:18:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196373

Powered by Google App Engine
This is Rietveld 408576698