Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1191573003: Add a basic enum for ARM InstructionSet / cpu features. (Closed)

Created:
5 years, 6 months ago by jvoung (off chromium)
Modified:
5 years, 6 months ago
Reviewers:
Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a basic enum for ARM InstructionSet / cpu features. That way, we don't have to use -mattr=sse2 for ARM in cross tests, etc. Default to NEON for now. Also put in an entry for HW divide in ARM mode. There's bunches of features that are possible though, e.g.,: https://github.com/llvm-mirror/llvm/blob/master/lib/Target/ARM/ARM.td BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d062f73a671032d93860dfb2774a7fa4acd0a0ae

Patch Set 1 #

Patch Set 2 : really set the default #

Patch Set 3 : comment #

Total comments: 2

Patch Set 4 : plus begin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -12 lines) Patch
M src/IceClFlags.cpp View 1 1 chunk +10 lines, -4 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 3 1 chunk +15 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download
M src/IceTypes.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jvoung (off chromium)
5 years, 6 months ago (2015-06-15 20:39:25 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/1191573003/diff/40001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/1191573003/diff/40001/src/IceTargetLoweringX8632.cpp#newcode407 src/IceTargetLoweringX8632.cpp:407: InstructionSet = static_cast<X86InstructionSet>( Seems like this should be getTargetInstructionSet() ...
5 years, 6 months ago (2015-06-15 21:46:01 UTC) #4
jvoung (off chromium)
https://codereview.chromium.org/1191573003/diff/40001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/1191573003/diff/40001/src/IceTargetLoweringX8632.cpp#newcode407 src/IceTargetLoweringX8632.cpp:407: InstructionSet = static_cast<X86InstructionSet>( On 2015/06/15 21:46:01, stichnot wrote: > ...
5 years, 6 months ago (2015-06-15 23:58:19 UTC) #5
Jim Stichnoth
lgtm
5 years, 6 months ago (2015-06-16 00:09:50 UTC) #6
jvoung (off chromium)
5 years, 6 months ago (2015-06-16 00:17:34 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
d062f73a671032d93860dfb2774a7fa4acd0a0ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698