Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1190503002: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (3) (Closed)

Created:
5 years, 6 months ago by nhiroki
Modified:
5 years, 6 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@route_web_sw_reg_1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (3) This is a part of refactoring CLs for unregister(). See the CL[1] for details. This CL actually switches unregister() callpath. [1] Blink: https://codereview.chromium.org/1185483003/ [2] Chromium: https://codereview.chromium.org/1181973004 [3] Blink: THIS PATCH [4] Chromium: https://codereview.chromium.org/1186803002 BUG=500404 TEST=run_layout_tests.sh http/tests/serviceworker/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197421

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 1 chunk +1 line, -10 lines 0 comments Download
M public/platform/WebServiceWorkerProvider.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
nhiroki
ptal
5 years, 6 months ago (2015-06-16 02:08:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190503002/20001
5 years, 6 months ago (2015-06-19 00:39:59 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/38855)
5 years, 6 months ago (2015-06-19 00:49:00 UTC) #6
nhiroki
ksakamoto@, can you take a look at this?
5 years, 6 months ago (2015-06-19 01:33:17 UTC) #8
Kunihiko Sakamoto
lgtm
5 years, 6 months ago (2015-06-19 01:57:10 UTC) #9
nhiroki
+tkent@ for WebServiceWorkerProvider.h, PTAL
5 years, 6 months ago (2015-06-19 02:00:22 UTC) #11
tkent
lgtm
5 years, 6 months ago (2015-06-19 02:13:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190503002/20001
5 years, 6 months ago (2015-06-19 02:14:11 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 02:30:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197421

Powered by Google App Engine
This is Rietveld 408576698