Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1186803002: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (4) (Closed)

Created:
5 years, 6 months ago by nhiroki
Modified:
5 years, 6 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@route_web_sw_reg_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (4) This is a part of refactoring CLs for unregister(). See the CL[1] for details. This CL cleans up transition codes in Chromium. [1] Blink: https://codereview.chromium.org/1185483003 [2] Chromium: https://codereview.chromium.org/1181973004 [3] Blink: https://codereview.chromium.org/1190503002 [4] Chromium: THIS PATCH BUG=500404 TEST=content_unittests --gtest_filter=ServiceWorker* Committed: https://crrev.com/ecf8fa2421b29a84eff93320280afdc70c5a1aaf Cr-Commit-Position: refs/heads/master@{#335225}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -135 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 2 chunks +0 lines, -76 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 2 2 chunks +25 lines, -1 line 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 1 chunk +0 lines, -28 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nhiroki
Ptal, thanks!
5 years, 6 months ago (2015-06-19 01:34:14 UTC) #2
Kunihiko Sakamoto
lgtm
5 years, 6 months ago (2015-06-19 02:04:17 UTC) #3
nhiroki
+mkwst@ for service_worker_messages.h, PTAL
5 years, 6 months ago (2015-06-19 05:25:07 UTC) #5
Mike West
On 2015/06/19 at 05:25:07, nhiroki wrote: > +mkwst@ for service_worker_messages.h, PTAL Removing deprecated IPC message ...
5 years, 6 months ago (2015-06-19 05:34:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186803002/40001
5 years, 6 months ago (2015-06-19 06:27:21 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-19 08:31:51 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 08:33:09 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ecf8fa2421b29a84eff93320280afdc70c5a1aaf
Cr-Commit-Position: refs/heads/master@{#335225}

Powered by Google App Engine
This is Rietveld 408576698