public/platform/WebServiceWorkerProvider.h - Issue 1190503002: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebServiceWorkerProvider.h

Issue 1190503002: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@route_web_sw_reg_1

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebServiceWorkerProvider.h

diff --git a/public/platform/WebServiceWorkerProvider.h b/public/platform/WebServiceWorkerProvider.h

index 1ba98964006fed35552dc0ee23318ab80154742d..0bdc5fee622a87ad0e0156dc91d8f3b0aeeb4215 100644

--- a/public/platform/WebServiceWorkerProvider.h

+++ b/public/platform/WebServiceWorkerProvider.h

@@ -59,12 +59,6 @@ public:

typedef WebCallbacks<WebServiceWorkerRegistration, void> WebServiceWorkerGetRegistrationForReadyCallbacks;

virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerRegistrationCallbacks*) { }

- // TODO(nhiroki): Remove after http://crbug.com/500404 is fixed.

-#define CRBUG_500404

- typedef WebCallbacks<bool, WebServiceWorkerError> WebServiceWorkerUnregistrationCallbacks;

- virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerUnregistrationCallbacks*) { }

virtual void getRegistration(const WebURL& documentURL, WebServiceWorkerGetRegistrationCallbacks*) { }

virtual void getRegistrations(WebServiceWorkerGetRegistrationsCallbacks*) { }

virtual void getRegistrationForReady(WebServiceWorkerGetRegistrationForReadyCallbacks*) { }

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerRegistration.cpp ('k') | no next file » | no next file with comments »