Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 11896047: Move the methods in disposition_utils.h and event_disposition.h to ui\base\window_open_disposition.… (Closed)

Created:
7 years, 11 months ago by jam
Modified:
7 years, 11 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, jeremya+watch_chromium.org, yoshiki+watch_chromium.org, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, rouslan+watch_chromium.org, aboxhall+watch_chromium.org, gbillock+watch_chromium.org, chromium-apps-reviews_chromium.org, Avi (use Gerrit), groby+watch_chromium.org, creis+watch_chromium.org, yuzo+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, sail+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, smckay+watch_chromium.org
Visibility:
Public.

Description

Move the methods in disposition_utils.h and event_disposition.h to ui\base\window_open_disposition.h. They'll be needed in code that will move to ui\webui. BUG=169170, 132903 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178192

Patch Set 1 #

Patch Set 2 : fix regex in ui.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -150 lines) Patch
D chrome/browser/disposition_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/disposition_utils.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/event_disposition.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/event_disposition.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search_builder.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/event_utils.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_sub_menu_model_gtk.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/event_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/other_device_menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/accessibility/invert_bubble_view.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/missing_system_file_dialog_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/network_profile_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/reload_button.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/generic_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_util.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/base/window_open_disposition.h View 2 chunks +20 lines, -0 lines 0 comments Download
A ui/base/window_open_disposition.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
7 years, 11 months ago (2013-01-22 22:23:39 UTC) #1
tfarina
John, this also address this crbug.com/132903 I filed, but never stopped to do. Could you ...
7 years, 11 months ago (2013-01-23 00:24:58 UTC) #2
jam
On 2013/01/23 00:24:58, tfarina wrote: > John, this also address this crbug.com/132903 I filed, but ...
7 years, 11 months ago (2013-01-23 00:31:35 UTC) #3
Ben Goodger (Google)
7 years, 11 months ago (2013-01-23 00:37:49 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698