Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: chrome/browser/ui/webui/generic_handler.cc

Issue 11896047: Move the methods in disposition_utils.h and event_disposition.h to ui\base\window_open_disposition.… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix regex in ui.gyp Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/generic_handler.h" 5 #include "chrome/browser/ui/webui/generic_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/browser/disposition_utils.h"
12 #include "content/public/browser//web_ui.h" 11 #include "content/public/browser//web_ui.h"
13 #include "content/public/browser/web_contents.h" 12 #include "content/public/browser/web_contents.h"
13 #include "ui/base/window_open_disposition.h"
14 14
15 using content::OpenURLParams; 15 using content::OpenURLParams;
16 16
17 GenericHandler::GenericHandler() { 17 GenericHandler::GenericHandler() {
18 } 18 }
19 19
20 GenericHandler::~GenericHandler() { 20 GenericHandler::~GenericHandler() {
21 } 21 }
22 22
23 void GenericHandler::RegisterMessages() { 23 void GenericHandler::RegisterMessages() {
(...skipping 14 matching lines...) Expand all
38 CHECK(args->GetString(1, &target_string)); 38 CHECK(args->GetString(1, &target_string));
39 CHECK(args->GetDouble(2, &button)); 39 CHECK(args->GetDouble(2, &button));
40 CHECK(args->GetBoolean(3, &alt_key)); 40 CHECK(args->GetBoolean(3, &alt_key));
41 CHECK(args->GetBoolean(4, &ctrl_key)); 41 CHECK(args->GetBoolean(4, &ctrl_key));
42 CHECK(args->GetBoolean(5, &meta_key)); 42 CHECK(args->GetBoolean(5, &meta_key));
43 CHECK(args->GetBoolean(6, &shift_key)); 43 CHECK(args->GetBoolean(6, &shift_key));
44 44
45 CHECK(button == 0.0 || button == 1.0); 45 CHECK(button == 0.0 || button == 1.0);
46 bool middle_button = (button == 1.0); 46 bool middle_button = (button == 1.0);
47 47
48 WindowOpenDisposition disposition = 48 WindowOpenDisposition disposition = ui::DispositionFromClick(
49 disposition_utils::DispositionFromClick(middle_button, alt_key, ctrl_key, 49 middle_button, alt_key, ctrl_key, meta_key, shift_key);
50 meta_key, shift_key);
51 if (disposition == CURRENT_TAB && target_string == "_blank") 50 if (disposition == CURRENT_TAB && target_string == "_blank")
52 disposition = NEW_FOREGROUND_TAB; 51 disposition = NEW_FOREGROUND_TAB;
53 52
54 web_ui()->GetWebContents()->OpenURL(OpenURLParams( 53 web_ui()->GetWebContents()->OpenURL(OpenURLParams(
55 GURL(url_string), content::Referrer(), disposition, 54 GURL(url_string), content::Referrer(), disposition,
56 content::PAGE_TRANSITION_LINK, false)); 55 content::PAGE_TRANSITION_LINK, false));
57 56
58 // This may delete us! 57 // This may delete us!
59 } 58 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/web_intent_picker_views.cc ('k') | chrome/browser/ui/webui/web_ui_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698