Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Side by Side Diff: chrome/browser/ui/toolbar/back_forward_menu_model.cc

Issue 11896047: Move the methods in disposition_utils.h and event_disposition.h to ui\base\window_open_disposition.… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix regex in ui.gyp Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #include "chrome/browser/ui/toolbar/back_forward_menu_model.h" 7 #include "chrome/browser/ui/toolbar/back_forward_menu_model.h"
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/string_number_conversions.h" 11 #include "base/string_number_conversions.h"
12 #include "chrome/browser/event_disposition.h"
13 #include "chrome/browser/favicon/favicon_service_factory.h" 12 #include "chrome/browser/favicon/favicon_service_factory.h"
14 #include "chrome/browser/prefs/pref_service.h" 13 #include "chrome/browser/prefs/pref_service.h"
15 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/ui/browser.h" 15 #include "chrome/browser/ui/browser.h"
17 #include "chrome/browser/ui/browser_commands.h" 16 #include "chrome/browser/ui/browser_commands.h"
18 #include "chrome/browser/ui/browser_tabstrip.h" 17 #include "chrome/browser/ui/browser_tabstrip.h"
19 #include "chrome/browser/ui/singleton_tabs.h" 18 #include "chrome/browser/ui/singleton_tabs.h"
20 #include "chrome/common/pref_names.h" 19 #include "chrome/common/pref_names.h"
21 #include "chrome/common/url_constants.h" 20 #include "chrome/common/url_constants.h"
22 #include "content/public/browser/favicon_status.h" 21 #include "content/public/browser/favicon_status.h"
23 #include "content/public/browser/navigation_controller.h" 22 #include "content/public/browser/navigation_controller.h"
24 #include "content/public/browser/navigation_entry.h" 23 #include "content/public/browser/navigation_entry.h"
25 #include "content/public/browser/user_metrics.h" 24 #include "content/public/browser/user_metrics.h"
26 #include "content/public/browser/web_contents.h" 25 #include "content/public/browser/web_contents.h"
27 #include "grit/generated_resources.h" 26 #include "grit/generated_resources.h"
28 #include "grit/theme_resources.h" 27 #include "grit/theme_resources.h"
29 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" 28 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
30 #include "ui/base/l10n/l10n_util.h" 29 #include "ui/base/l10n/l10n_util.h"
31 #include "ui/base/resource/resource_bundle.h" 30 #include "ui/base/resource/resource_bundle.h"
32 #include "ui/base/text/text_elider.h" 31 #include "ui/base/text/text_elider.h"
32 #include "ui/base/window_open_disposition.h"
33 #include "ui/gfx/favicon_size.h" 33 #include "ui/gfx/favicon_size.h"
34 34
35 using content::NavigationController; 35 using content::NavigationController;
36 using content::NavigationEntry; 36 using content::NavigationEntry;
37 using content::UserMetricsAction; 37 using content::UserMetricsAction;
38 using content::WebContents; 38 using content::WebContents;
39 39
40 const int BackForwardMenuModel::kMaxHistoryItems = 12; 40 const int BackForwardMenuModel::kMaxHistoryItems = 12;
41 const int BackForwardMenuModel::kMaxChapterStops = 5; 41 const int BackForwardMenuModel::kMaxChapterStops = 5;
42 static const int kMaxWidth = 700; 42 static const int kMaxWidth = 700;
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 if (index < GetHistoryItemCount()) { 192 if (index < GetHistoryItemCount()) {
193 content::RecordComputedAction( 193 content::RecordComputedAction(
194 BuildActionName("HistoryClick", index)); 194 BuildActionName("HistoryClick", index));
195 } else { 195 } else {
196 content::RecordComputedAction( 196 content::RecordComputedAction(
197 BuildActionName("ChapterClick", index - GetHistoryItemCount() - 1)); 197 BuildActionName("ChapterClick", index - GetHistoryItemCount() - 1));
198 } 198 }
199 199
200 int controller_index = MenuIndexToNavEntryIndex(index); 200 int controller_index = MenuIndexToNavEntryIndex(index);
201 WindowOpenDisposition disposition = 201 WindowOpenDisposition disposition =
202 chrome::DispositionFromEventFlags(event_flags); 202 ui::DispositionFromEventFlags(event_flags);
203 if (!chrome::NavigateToIndexWithDisposition(browser_, 203 if (!chrome::NavigateToIndexWithDisposition(browser_,
204 controller_index, 204 controller_index,
205 disposition)) { 205 disposition)) {
206 NOTREACHED(); 206 NOTREACHED();
207 } 207 }
208 } 208 }
209 209
210 void BackForwardMenuModel::MenuWillShow() { 210 void BackForwardMenuModel::MenuWillShow() {
211 content::RecordComputedAction(BuildActionName("Popup", -1)); 211 content::RecordComputedAction(BuildActionName("Popup", -1));
212 requested_favicons_.clear(); 212 requested_favicons_.clear();
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 metric_string += "ForwardMenu_"; 474 metric_string += "ForwardMenu_";
475 else 475 else
476 metric_string += "BackMenu_"; 476 metric_string += "BackMenu_";
477 metric_string += action; 477 metric_string += action;
478 if (index != -1) { 478 if (index != -1) {
479 // +1 is for historical reasons (indices used to start at 1). 479 // +1 is for historical reasons (indices used to start at 1).
480 metric_string += base::IntToString(index + 1); 480 metric_string += base::IntToString(index + 1);
481 } 481 }
482 return metric_string; 482 return metric_string;
483 } 483 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/search/other_device_menu_controller.cc ('k') | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698