content/browser/frame_host/navigation_entry_impl.h - Issue 1189413005: Fix race when reloading original URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 1189413005: Fix race when reloading original URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing unittests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_entry_impl.h

diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h

index e6c7d7c44e3d608f5490628e4f6c960f9af7f429..507e3558e21d3f04f491aabbada69bc7711e024d 100644

--- a/content/browser/frame_host/navigation_entry_impl.h

+++ b/content/browser/frame_host/navigation_entry_impl.h

@@ -145,6 +145,8 @@ class CONTENT_EXPORT NavigationEntryImpl

// NavigationEntry.

CommonNavigationParams ConstructCommonNavigationParams(

const FrameNavigationEntry& frame_entry,

+ const GURL& dest_url,

+ const Referrer& dest_referrer,

Charlie Reis 2015/07/14 22:23:10 nit: List these before frame_entry since they take

lfg 2015/07/14 22:47:27 Done.

FrameMsg_Navigate_Type::Value navigation_type) const;

StartNavigationParams ConstructStartNavigationParams() const;

RequestNavigationParams ConstructRequestNavigationParams(