Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1189413005: Fix race when reloading original URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing unittests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index 5e47912398bed6bf721136e8b2ae7b979241052d..a8b515292435b624a0e58cd25c545fb72e446352 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -436,6 +436,8 @@ scoped_ptr<NavigationEntryImpl> NavigationEntryImpl::CloneAndReplace(
CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
const FrameNavigationEntry& frame_entry,
+ const GURL& dest_url,
+ const Referrer& dest_referrer,
FrameMsg_Navigate_Type::Value navigation_type) const {
FrameMsg_UILoadMetricsReportType::Value report_type =
FrameMsg_UILoadMetricsReportType::NO_REPORT;
@@ -447,9 +449,9 @@ CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
#endif
return CommonNavigationParams(
- frame_entry.url(), frame_entry.referrer(), GetTransitionType(),
- navigation_type, !IsViewSourceMode(), ui_timestamp, report_type,
- GetBaseURLForDataURL(), GetHistoryURLForDataURL());
+ dest_url, dest_referrer, GetTransitionType(), navigation_type,
+ !IsViewSourceMode(), ui_timestamp, report_type, GetBaseURLForDataURL(),
+ GetHistoryURLForDataURL());
}
StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams()

Powered by Google App Engine
This is Rietveld 408576698