Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 1189413005: Fix race when reloading original URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing unittests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_vector.h" 10 #include "base/memory/scoped_vector.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 // NavigationEntryImpls, we will need to support two versions of Clone: one 138 // NavigationEntryImpls, we will need to support two versions of Clone: one
139 // that shares the existing FrameNavigationEntries (for use within the same 139 // that shares the existing FrameNavigationEntries (for use within the same
140 // tab) and one that draws them from a different pool (for use in a new tab). 140 // tab) and one that draws them from a different pool (for use in a new tab).
141 scoped_ptr<NavigationEntryImpl> CloneAndReplace( 141 scoped_ptr<NavigationEntryImpl> CloneAndReplace(
142 FrameTreeNode* frame_tree_node, FrameNavigationEntry* frame_entry) const; 142 FrameTreeNode* frame_tree_node, FrameNavigationEntry* frame_entry) const;
143 143
144 // Helper functions to construct NavigationParameters for a navigation to this 144 // Helper functions to construct NavigationParameters for a navigation to this
145 // NavigationEntry. 145 // NavigationEntry.
146 CommonNavigationParams ConstructCommonNavigationParams( 146 CommonNavigationParams ConstructCommonNavigationParams(
147 const FrameNavigationEntry& frame_entry, 147 const FrameNavigationEntry& frame_entry,
148 const GURL& dest_url,
149 const Referrer& dest_referrer,
Charlie Reis 2015/07/14 22:23:10 nit: List these before frame_entry since they take
lfg 2015/07/14 22:47:27 Done.
148 FrameMsg_Navigate_Type::Value navigation_type) const; 150 FrameMsg_Navigate_Type::Value navigation_type) const;
149 StartNavigationParams ConstructStartNavigationParams() const; 151 StartNavigationParams ConstructStartNavigationParams() const;
150 RequestNavigationParams ConstructRequestNavigationParams( 152 RequestNavigationParams ConstructRequestNavigationParams(
151 const FrameNavigationEntry& frame_entry, 153 const FrameNavigationEntry& frame_entry,
152 base::TimeTicks navigation_start, 154 base::TimeTicks navigation_start,
153 bool is_same_document_history_load, 155 bool is_same_document_history_load,
154 bool has_committed_real_load, 156 bool has_committed_real_load,
155 bool intended_as_new_entry, 157 bool intended_as_new_entry,
156 int pending_offset_to_send, 158 int pending_offset_to_send,
157 int current_offset_to_send, 159 int current_offset_to_send,
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 // persisted, unless specific data is taken out/put back in at save/restore 466 // persisted, unless specific data is taken out/put back in at save/restore
465 // time (see TabNavigation for an example of this). 467 // time (see TabNavigation for an example of this).
466 std::map<std::string, base::string16> extra_data_; 468 std::map<std::string, base::string16> extra_data_;
467 469
468 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl); 470 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
469 }; 471 };
470 472
471 } // namespace content 473 } // namespace content
472 474
473 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 475 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698