Removing PasswordForm::password_auto_complete_set

Removing PasswordForm::password_auto_complete_set

BUG=501559
Committed: https://crrev.com/394674f77ff069853d0df59918e23bd13ef3861f
Cr-Commit-Position: refs/heads/master@{#335445}

[Paritosh Kumar, 2015-06-19 13:56:44]

The CQ bit was checked by paritosh.in@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-19 13:57:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1189293003/1

[commit-bot: I haz the power, 2015-06-19 14:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 14:13:01]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Paritosh Kumar, 2015-06-19 14:17:48]

The CQ bit was checked by paritosh.in@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-19 14:18:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1189293003/20001

[commit-bot: I haz the power, 2015-06-19 15:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 15:37:31]

Dry run: This issue passed the CQ dry run.

[Paritosh Kumar, 2015-06-19 16:07:04]

paritosh.in@samsung.com changed reviewers:
+ gcasto@chromium.org, vabr@chromium.org

[Paritosh Kumar, 2015-06-19 16:07:05]

Please have a look.

[vabr (Chromium), 2015-06-19 16:25:11]

LGTM with two comments. Please address them before landing.
Thanks!
Vaclav

https://codereview.chromium.org/1189293003/diff/20001/components/password_man...
File components/password_manager/core/browser/password_manager_unittest.cc
(left):

https://codereview.chromium.org/1189293003/diff/20001/components/password_man...
components/password_manager/core/browser/password_manager_unittest.cc:598:
TEST_F(PasswordManagerTest, FormSavedWithAutocompleteOff) {
Please delete this test completely.
Without the autocomplete bit, this is basically the same as
FormSubmitEmptyStore.

https://codereview.chromium.org/1189293003/diff/20001/components/password_man...
components/password_manager/core/browser/password_manager_unittest.cc:632:
TEST_F(PasswordManagerTest, GeneratedPasswordFormSavedAutocompleteOff) {
Remove this test completely, it is the same as
GeneratedPasswordFormSubmitEmptyStore.

[vabr (Chromium), 2015-06-19 16:26:42]

Also please, until you get bug editing privileges, leave a comment on the
associated bug next time before you write a patch. That will avoid work
duplication (yes, this happened before).

Thanks!
Vaclav

[Paritosh Kumar, 2015-06-20 08:23:14]

On 2015/06/19 16:25:11, vabr (OOO until 29 June) wrote:
> LGTM with two comments. Please address them before landing.
> Thanks!
> Vaclav
> 
>
https://codereview.chromium.org/1189293003/diff/20001/components/password_man...
> File components/password_manager/core/browser/password_manager_unittest.cc
> (left):
> 
>
https://codereview.chromium.org/1189293003/diff/20001/components/password_man...
> components/password_manager/core/browser/password_manager_unittest.cc:598:
> TEST_F(PasswordManagerTest, FormSavedWithAutocompleteOff) {
> Please delete this test completely.
> Without the autocomplete bit, this is basically the same as
> FormSubmitEmptyStore.
> 
>
https://codereview.chromium.org/1189293003/diff/20001/components/password_man...
> components/password_manager/core/browser/password_manager_unittest.cc:632:
> TEST_F(PasswordManagerTest, GeneratedPasswordFormSavedAutocompleteOff) {
> Remove this test completely, it is the same as
> GeneratedPasswordFormSubmitEmptyStore.

Thanks Vaclav
Updated.

[Paritosh Kumar, 2015-06-20 08:23:27]

The CQ bit was checked by paritosh.in@samsung.com to run a CQ dry run

[Paritosh Kumar, 2015-06-20 08:23:27]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1189293003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-06-20 08:23:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1189293003/40001

[commit-bot: I haz the power, 2015-06-20 09:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-20 09:22:28]

Dry run: This issue passed the CQ dry run.

[Paritosh Kumar, 2015-06-20 18:40:07]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2015-06-20 18:40:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1189293003/40001

[commit-bot: I haz the power, 2015-06-20 18:43:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-20 18:44:06]

Patchset 3 (id:??) landed as
https://crrev.com/394674f77ff069853d0df59918e23bd13ef3861f
Cr-Commit-Position: refs/heads/master@{#335445}