Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: components/autofill/core/common/password_form.cc

Issue 1189293003: Removing PasswordForm::password_auto_complete_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <ostream> 5 #include <ostream>
6 #include <sstream> 6 #include <sstream>
7 7
8 #include "base/json/json_writer.h" 8 #include "base/json/json_writer.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 19 matching lines...) Expand all
30 target->SetBoolean("username_marked_by_site", form.username_marked_by_site); 30 target->SetBoolean("username_marked_by_site", form.username_marked_by_site);
31 target->SetString("username_value", form.username_value); 31 target->SetString("username_value", form.username_value);
32 target->SetString("password_elem", form.password_element); 32 target->SetString("password_elem", form.password_element);
33 target->SetString("password_value", form.password_value); 33 target->SetString("password_value", form.password_value);
34 target->SetString("new_password_element", form.new_password_element); 34 target->SetString("new_password_element", form.new_password_element);
35 target->SetString("new_password_value", form.new_password_value); 35 target->SetString("new_password_value", form.new_password_value);
36 target->SetBoolean("new_password_marked_by_site", 36 target->SetBoolean("new_password_marked_by_site",
37 form.new_password_marked_by_site); 37 form.new_password_marked_by_site);
38 target->SetString("other_possible_usernames", 38 target->SetString("other_possible_usernames",
39 JoinString(form.other_possible_usernames, '|')); 39 JoinString(form.other_possible_usernames, '|'));
40 target->SetBoolean("autocomplete_set", form.password_autocomplete_set);
41 target->SetBoolean("blacklisted", form.blacklisted_by_user); 40 target->SetBoolean("blacklisted", form.blacklisted_by_user);
42 target->SetBoolean("preferred", form.preferred); 41 target->SetBoolean("preferred", form.preferred);
43 target->SetBoolean("ssl_valid", form.ssl_valid); 42 target->SetBoolean("ssl_valid", form.ssl_valid);
44 target->SetDouble("date_created", form.date_created.ToDoubleT()); 43 target->SetDouble("date_created", form.date_created.ToDoubleT());
45 target->SetDouble("date_synced", form.date_synced.ToDoubleT()); 44 target->SetDouble("date_synced", form.date_synced.ToDoubleT());
46 target->SetInteger("type", form.type); 45 target->SetInteger("type", form.type);
47 target->SetInteger("times_used", form.times_used); 46 target->SetInteger("times_used", form.times_used);
48 std::ostringstream form_data_string_stream; 47 std::ostringstream form_data_string_stream;
49 form_data_string_stream << form.form_data; 48 form_data_string_stream << form.form_data;
50 target->SetString("form_data", form_data_string_stream.str()); 49 target->SetString("form_data", form_data_string_stream.str());
51 target->SetInteger("generation_upload_status", form.generation_upload_status); 50 target->SetInteger("generation_upload_status", form.generation_upload_status);
52 target->SetString("display_name", form.display_name); 51 target->SetString("display_name", form.display_name);
53 target->SetString("avatar_url", form.avatar_url.possibly_invalid_spec()); 52 target->SetString("avatar_url", form.avatar_url.possibly_invalid_spec());
54 target->SetString("federation_url", 53 target->SetString("federation_url",
55 form.federation_url.possibly_invalid_spec()); 54 form.federation_url.possibly_invalid_spec());
56 target->SetBoolean("skip_next_zero_click", form.skip_zero_click); 55 target->SetBoolean("skip_next_zero_click", form.skip_zero_click);
57 std::ostringstream layout_string_stream; 56 std::ostringstream layout_string_stream;
58 layout_string_stream << form.layout; 57 layout_string_stream << form.layout;
59 target->SetString("layout", layout_string_stream.str()); 58 target->SetString("layout", layout_string_stream.str());
60 target->SetBoolean("was_parsed_using_autofill_predictions", 59 target->SetBoolean("was_parsed_using_autofill_predictions",
61 form.was_parsed_using_autofill_predictions); 60 form.was_parsed_using_autofill_predictions);
62 } 61 }
63 62
64 } // namespace 63 } // namespace
65 64
66 PasswordForm::PasswordForm() 65 PasswordForm::PasswordForm()
67 : scheme(SCHEME_HTML), 66 : scheme(SCHEME_HTML),
68 username_marked_by_site(false), 67 username_marked_by_site(false),
69 password_autocomplete_set(true),
70 new_password_marked_by_site(false), 68 new_password_marked_by_site(false),
71 ssl_valid(false), 69 ssl_valid(false),
72 preferred(false), 70 preferred(false),
73 blacklisted_by_user(false), 71 blacklisted_by_user(false),
74 type(TYPE_MANUAL), 72 type(TYPE_MANUAL),
75 times_used(0), 73 times_used(0),
76 generation_upload_status(NO_SIGNAL_SENT), 74 generation_upload_status(NO_SIGNAL_SENT),
77 skip_zero_click(false), 75 skip_zero_click(false),
78 layout(Layout::LAYOUT_OTHER), 76 layout(Layout::LAYOUT_OTHER),
79 was_parsed_using_autofill_predictions(false), 77 was_parsed_using_autofill_predictions(false),
(...skipping 16 matching lines...) Expand all
96 original_signon_realm == form.original_signon_realm && 94 original_signon_realm == form.original_signon_realm &&
97 origin == form.origin && 95 origin == form.origin &&
98 action == form.action && 96 action == form.action &&
99 submit_element == form.submit_element && 97 submit_element == form.submit_element &&
100 username_element == form.username_element && 98 username_element == form.username_element &&
101 username_marked_by_site == form.username_marked_by_site && 99 username_marked_by_site == form.username_marked_by_site &&
102 username_value == form.username_value && 100 username_value == form.username_value &&
103 other_possible_usernames == form.other_possible_usernames && 101 other_possible_usernames == form.other_possible_usernames &&
104 password_element == form.password_element && 102 password_element == form.password_element &&
105 password_value == form.password_value && 103 password_value == form.password_value &&
106 password_autocomplete_set == form.password_autocomplete_set &&
107 new_password_element == form.new_password_element && 104 new_password_element == form.new_password_element &&
108 new_password_marked_by_site == form.new_password_marked_by_site && 105 new_password_marked_by_site == form.new_password_marked_by_site &&
109 new_password_value == form.new_password_value && 106 new_password_value == form.new_password_value &&
110 ssl_valid == form.ssl_valid && 107 ssl_valid == form.ssl_valid &&
111 preferred == form.preferred && 108 preferred == form.preferred &&
112 date_created == form.date_created && 109 date_created == form.date_created &&
113 date_synced == form.date_synced && 110 date_synced == form.date_synced &&
114 blacklisted_by_user == form.blacklisted_by_user && 111 blacklisted_by_user == form.blacklisted_by_user &&
115 type == form.type && 112 type == form.type &&
116 times_used == form.times_used && 113 times_used == form.times_used &&
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 form_json, base::JSONWriter::OPTIONS_PRETTY_PRINT, &form_as_string); 160 form_json, base::JSONWriter::OPTIONS_PRETTY_PRINT, &form_as_string);
164 base::TrimWhitespaceASCII(form_as_string, base::TRIM_ALL, &form_as_string); 161 base::TrimWhitespaceASCII(form_as_string, base::TRIM_ALL, &form_as_string);
165 return os << "PasswordForm(" << form_as_string << ")"; 162 return os << "PasswordForm(" << form_as_string << ")";
166 } 163 }
167 164
168 std::ostream& operator<<(std::ostream& os, PasswordForm* form) { 165 std::ostream& operator<<(std::ostream& os, PasswordForm* form) {
169 return os << "&" << *form; 166 return os << "&" << *form;
170 } 167 }
171 168
172 } // namespace autofill 169 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/common/password_form.h ('k') | components/autofill/core/common/save_password_progress_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698