Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 1189293003: Removing PasswordForm::password_auto_complete_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/common/save_password_progress_logger.h" 5 #include "components/autofill/core/common/save_password_progress_logger.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/json/json_writer.h" 9 #include "base/json/json_writer.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 log.SetString(GetStringFromID(STRING_SIGNON_REALM), 80 log.SetString(GetStringFromID(STRING_SIGNON_REALM),
81 ScrubURL(GURL(form.signon_realm))); 81 ScrubURL(GURL(form.signon_realm)));
82 log.SetString(GetStringFromID(STRING_ORIGINAL_SIGNON_REALM), 82 log.SetString(GetStringFromID(STRING_ORIGINAL_SIGNON_REALM),
83 ScrubURL(GURL(form.original_signon_realm))); 83 ScrubURL(GURL(form.original_signon_realm)));
84 log.SetString(GetStringFromID(STRING_ORIGIN), ScrubURL(form.origin)); 84 log.SetString(GetStringFromID(STRING_ORIGIN), ScrubURL(form.origin));
85 log.SetString(GetStringFromID(STRING_ACTION), ScrubURL(form.action)); 85 log.SetString(GetStringFromID(STRING_ACTION), ScrubURL(form.action));
86 log.SetString(GetStringFromID(STRING_USERNAME_ELEMENT), 86 log.SetString(GetStringFromID(STRING_USERNAME_ELEMENT),
87 ScrubElementID(form.username_element)); 87 ScrubElementID(form.username_element));
88 log.SetString(GetStringFromID(STRING_PASSWORD_ELEMENT), 88 log.SetString(GetStringFromID(STRING_PASSWORD_ELEMENT),
89 ScrubElementID(form.password_element)); 89 ScrubElementID(form.password_element));
90 log.SetBoolean(GetStringFromID(STRING_PASSWORD_AUTOCOMPLETE_SET),
91 form.password_autocomplete_set);
92 log.SetString(GetStringFromID(STRING_NEW_PASSWORD_ELEMENT), 90 log.SetString(GetStringFromID(STRING_NEW_PASSWORD_ELEMENT),
93 ScrubElementID(form.new_password_element)); 91 ScrubElementID(form.new_password_element));
94 log.SetBoolean(GetStringFromID(STRING_SSL_VALID), form.ssl_valid); 92 log.SetBoolean(GetStringFromID(STRING_SSL_VALID), form.ssl_valid);
95 log.SetBoolean(GetStringFromID(STRING_PASSWORD_GENERATED), 93 log.SetBoolean(GetStringFromID(STRING_PASSWORD_GENERATED),
96 form.type == PasswordForm::TYPE_GENERATED); 94 form.type == PasswordForm::TYPE_GENERATED);
97 log.SetInteger(GetStringFromID(STRING_TIMES_USED), form.times_used); 95 log.SetInteger(GetStringFromID(STRING_TIMES_USED), form.times_used);
98 log.SetBoolean(GetStringFromID(STRING_PSL_MATCH), form.IsPublicSuffixMatch()); 96 log.SetBoolean(GetStringFromID(STRING_PSL_MATCH), form.IsPublicSuffixMatch());
99 LogValue(label, log); 97 LogValue(label, log);
100 } 98 }
101 99
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 case SavePasswordProgressLogger::STRING_ORIGINAL_SIGNON_REALM: 186 case SavePasswordProgressLogger::STRING_ORIGINAL_SIGNON_REALM:
189 return "Original signon realm"; 187 return "Original signon realm";
190 case SavePasswordProgressLogger::STRING_ORIGIN: 188 case SavePasswordProgressLogger::STRING_ORIGIN:
191 return "Origin"; 189 return "Origin";
192 case SavePasswordProgressLogger::STRING_ACTION: 190 case SavePasswordProgressLogger::STRING_ACTION:
193 return "Action"; 191 return "Action";
194 case SavePasswordProgressLogger::STRING_USERNAME_ELEMENT: 192 case SavePasswordProgressLogger::STRING_USERNAME_ELEMENT:
195 return "Username element"; 193 return "Username element";
196 case SavePasswordProgressLogger::STRING_PASSWORD_ELEMENT: 194 case SavePasswordProgressLogger::STRING_PASSWORD_ELEMENT:
197 return "Password element"; 195 return "Password element";
198 case SavePasswordProgressLogger::STRING_PASSWORD_AUTOCOMPLETE_SET:
199 return "Password autocomplete set";
200 case SavePasswordProgressLogger::STRING_NEW_PASSWORD_ELEMENT: 196 case SavePasswordProgressLogger::STRING_NEW_PASSWORD_ELEMENT:
201 return "New password element"; 197 return "New password element";
202 case SavePasswordProgressLogger::STRING_SSL_VALID: 198 case SavePasswordProgressLogger::STRING_SSL_VALID:
203 return "SSL valid"; 199 return "SSL valid";
204 case SavePasswordProgressLogger::STRING_PASSWORD_GENERATED: 200 case SavePasswordProgressLogger::STRING_PASSWORD_GENERATED:
205 return "Password generated"; 201 return "Password generated";
206 case SavePasswordProgressLogger::STRING_TIMES_USED: 202 case SavePasswordProgressLogger::STRING_TIMES_USED:
207 return "Times used"; 203 return "Times used";
208 case SavePasswordProgressLogger::STRING_PSL_MATCH: 204 case SavePasswordProgressLogger::STRING_PSL_MATCH:
209 return "PSL match"; 205 return "PSL match";
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 return "Adding manager for form with this signature"; 350 return "Adding manager for form with this signature";
355 case SavePasswordProgressLogger::STRING_INVALID: 351 case SavePasswordProgressLogger::STRING_INVALID:
356 return "INVALID"; 352 return "INVALID";
357 // Intentionally no default: clause here -- all IDs need to get covered. 353 // Intentionally no default: clause here -- all IDs need to get covered.
358 } 354 }
359 NOTREACHED(); // Win compilers don't believe this is unreachable. 355 NOTREACHED(); // Win compilers don't believe this is unreachable.
360 return std::string(); 356 return std::string();
361 } 357 }
362 358
363 } // namespace autofill 359 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698