chrome/browser/extensions/api/notifications/notifications_apitest.cc - Issue 1188213002: Making icon url for buttons in notification optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/notifications_apitest.cc

Issue 1188213002: Making icon url for buttons in notification optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added Test case. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_api.cc ('k') | chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notifications/notifications_apitest.cc

diff --git a/chrome/browser/extensions/api/notifications/notifications_apitest.cc b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

index 014f19dba907f31f71545b14d0a4d1578388237d..9def0e611f50eef292408340ee220f259f242ed0 100644

--- a/chrome/browser/extensions/api/notifications/notifications_apitest.cc

+++ b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

@@ -164,6 +164,7 @@ IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestPartialUpdate) {

const char kNewTitle[] = "Changed!";

const char kNewMessage[] = "Too late! The show ended yesterday";

int kNewPriority = 2;

+ const char kButtonTitle[] = "NewButton";

const message_center::NotificationList::Notifications& notifications =

g_browser_process->message_center()->GetVisibleNotifications();

@@ -174,7 +175,8 @@ IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestPartialUpdate) {

EXPECT_EQ(base::ASCIIToUTF16(kNewTitle), notification->title());

EXPECT_EQ(base::ASCIIToUTF16(kNewMessage), notification->message());

EXPECT_EQ(kNewPriority, notification->priority());

- EXPECT_EQ(0u, notification->buttons().size());

+ EXPECT_EQ(1u, notification->buttons().size());

+ EXPECT_EQ(base::ASCIIToUTF16(kButtonTitle), notification->buttons()[0].title);

}

IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestGetPermissionLevel) {