Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6180)

Unified Diff: chrome/browser/extensions/api/notifications/notifications_api.cc

Issue 1188213002: Making icon url for buttons in notification optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added Test case. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/notifications/notifications_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/notifications/notifications_api.cc
diff --git a/chrome/browser/extensions/api/notifications/notifications_api.cc b/chrome/browser/extensions/api/notifications/notifications_api.cc
index 17063dfd5e6caff646f6feeded9b71303aa7908d..e5e6bf6cfaccfec160e9aac5de4021cea0c3ffc9 100644
--- a/chrome/browser/extensions/api/notifications/notifications_api.cc
+++ b/chrome/browser/extensions/api/notifications/notifications_api.cc
@@ -298,8 +298,8 @@ bool NotificationsApiFunction::CreateNotification(
NotificationConversionHelper::NotificationBitmapToGfxImage(
image_scale, bitmap_sizes.button_icon_size, *icon_bitmap_ptr,
&info.icon);
- optional_fields.buttons.push_back(info);
}
+ optional_fields.buttons.push_back(info);
}
}
@@ -434,8 +434,8 @@ bool NotificationsApiFunction::UpdateNotification(
NotificationConversionHelper::NotificationBitmapToGfxImage(
image_scale, bitmap_sizes.button_icon_size, *icon_bitmap_ptr,
&button.icon);
- buttons.push_back(button);
}
+ buttons.push_back(button);
}
notification->set_buttons(buttons);
}
« no previous file with comments | « no previous file | chrome/browser/extensions/api/notifications/notifications_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698