Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7306)

Unified Diff: chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js

Issue 1188213002: Making icon url for buttons in notification optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added Test case. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_apitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js
diff --git a/chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js b/chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js
index 756fc26587a33bda324eeede987ea675986ea49e..b42572f75e984893adef037bb396a6a6e6e85881 100644
--- a/chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js
+++ b/chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js
@@ -124,17 +124,19 @@ function testPartialUpdate() {
// Create a notification.
create("testId", basicNotificationOptions)
- // Then update a few items
- .then(function () {
- return update("testId", {
- title: "Changed!",
- message: "Too late! The show ended yesterday"
- });
- })
- // Then update a few more items
- .then(function () { return update("testId", {priority:2, buttons: []}); })
- // The test will continue in C++, checking that all the updates "took"
- .then(chrome.test.succeed, chrome.test.fail);
+ // Then update a few items
+ .then(function() {
+ return update("testId", {
+ title: "Changed!",
+ message: "Too late! The show ended yesterday"
+ });
+ })
+ // Then update a few more items
+ .then(function() {
+ return update("testId", {priority: 2, buttons: [{title: "NewButton"}]});
+ })
+ // The test will continue in C++, checking that all the updates "took"
+ .then(chrome.test.succeed, chrome.test.fail);
};
« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_apitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698