Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: tools/telemetry/telemetry/browser.py

Issue 11882033: Telemetry support for extensions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/browser.py
===================================================================
--- tools/telemetry/telemetry/browser.py (revision 179975)
+++ tools/telemetry/telemetry/browser.py (working copy)
@@ -4,6 +4,7 @@
import os
from telemetry import browser_credentials
+from telemetry import extension_dict
from telemetry import tab_list
from telemetry import temporary_http_server
from telemetry import wpr_modes
@@ -27,6 +28,10 @@
self._wpr_server = None
self._platform = platform
self._tabs = tab_list.TabList(browser_backend.tab_list_backend)
+ self._extensions = None
+ if not browser_backend.is_content_shell:
nduca 2013/02/01 00:25:50 android isn't content shell.... treat these separa
achuithb 2013/02/06 00:23:03 Done.
+ self._extensions = extension_dict.ExtensionDict(
+ browser_backend.extension_dict_backend)
self.credentials = browser_credentials.BrowserCredentials()
def __enter__(self):
@@ -57,6 +62,10 @@
return self._tabs
@property
nduca 2013/02/01 00:25:50 you dont have a supports_extensions property. you
achuithb 2013/02/06 00:23:03 Done.
+ def extensions(self):
nduca 2013/02/01 00:25:50 doc tring should say that this may not be there a
achuithb 2013/02/06 00:23:03 Done.
+ return self._extensions
+
+ @property
def supports_tracing(self):
return self._browser_backend.supports_tracing

Powered by Google App Engine
This is Rietveld 408576698