Telemetry support for extensions.

tools/telemetry/telemetry/browser.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import os
 
 from telemetry import browser_credentials
+from telemetry import extension_dict
 from telemetry import tab_list
 from telemetry import temporary_http_server
 from telemetry import wpr_modes
 from telemetry import wpr_server
 
 
 class Browser(object):
   """A running browser instance that can be controlled in a limited way.
 
   To create a browser instance, use browser_finder.FindBrowser.
 
   Be sure to clean up after yourself by calling Close() when you are done with
   the browser. Or better yet:
     browser_to_create = FindBrowser(options)
     with browser_to_create.Create() as browser:
       ... do all your operations on browser here
   """
   def __init__(self, browser_backend, platform):
     self._browser_backend = browser_backend
     self._http_server = None
     self._wpr_server = None
     self._platform = platform
     self._tabs = tab_list.TabList(browser_backend.tab_list_backend)
+    self._extensions = None
+    if not browser_backend.is_content_shell:

[nduca, 2013/02/01 00:25:50]

android isn't content shell.... treat these separately --- ask the browser
backend if it supports extensions

[achuithb, 2013/02/06 00:23:03]

Done.

+      self._extensions = extension_dict.ExtensionDict(
+          browser_backend.extension_dict_backend)
     self.credentials = browser_credentials.BrowserCredentials()
 
   def __enter__(self):
     return self
 
   def __exit__(self, *args):
     self.Close()
 
   @property
   def platform(self):
     return self._platform
 
   @property
   def browser_type(self):
     return self._browser_backend.browser_type
 
   @property
   def is_content_shell(self):
     """Returns whether this browser is a content shell, only."""
     return self._browser_backend.is_content_shell
 
   @property
   def supports_tab_control(self):
     return self._browser_backend.supports_tab_control
 
   @property
   def tabs(self):
     return self._tabs
 
   @property

[nduca, 2013/02/01 00:25:50]

you dont have a supports_extensions property. you should.

[achuithb, 2013/02/06 00:23:03]

Done.

+  def extensions(self):

[nduca, 2013/02/01 00:25:50]

doc tring should say that this may not be there

accessor should raise  special exception if its not supported

   raise ExtensionsNotSupportedException) or something

[achuithb, 2013/02/06 00:23:03]

Done.

+    return self._extensions
+
+  @property
   def supports_tracing(self):
     return self._browser_backend.supports_tracing
 
   def StartTracing(self):
     return self._browser_backend.StartTracing()
 
   def StopTracing(self):
     return self._browser_backend.StopTracing()
 
   def GetTraceResultAndReset(self):
@@ skipping 55 matching lines @@
         archive_path,
         use_record_mode,
         self._browser_backend.WEBPAGEREPLAY_HOST,
         self._browser_backend.webpagereplay_local_http_port,
         self._browser_backend.webpagereplay_local_https_port,
         self._browser_backend.webpagereplay_remote_http_port,
         self._browser_backend.webpagereplay_remote_https_port)
 
   def GetStandardOutput(self):
     return self._browser_backend.GetStandardOutput()