Chromium Code Reviews| Index: tools/telemetry/telemetry/browser_options.py |
| =================================================================== |
| --- tools/telemetry/telemetry/browser_options.py (revision 179975) |
| +++ tools/telemetry/telemetry/browser_options.py (working copy) |
| @@ -10,6 +10,11 @@ |
| from telemetry import browser_finder |
| from telemetry import wpr_modes |
| +class ExtensionToLoad(object): |
|
nduca
2013/02/01 00:25:50
This should be its own py file
achuithb
2013/02/06 00:23:03
Done.
|
| + def __init__(self, path, is_component): |
|
nduca
2013/02/01 00:25:50
load_as_component=False
achuithb
2013/02/06 00:23:03
Done.
|
| + self.path = path |
| + self.is_component = is_component |
|
nduca
2013/02/01 00:25:50
this should have an accessor for crx id
achuithb
2013/02/06 00:23:03
Done.
|
| + |
| class BrowserOptions(optparse.Values): |
| """Options to be used for discovering and launching a browser.""" |
| @@ -25,6 +30,7 @@ |
| self.dont_override_profile = False |
| self.extra_browser_args = [] |
| self.show_stdout = False |
| + self.extensions_to_load = [] |
| self.cros_remote = None |
| self.wpr_mode = wpr_modes.WPR_OFF |
| @@ -89,6 +95,12 @@ |
| group.add_option('--show-stdout', |
| action='store_true', |
| help='When possible, will display the stdout of the process') |
| + group.add_option('--load-component-extension', |
|
nduca
2013/02/01 00:25:50
Remove all the edits here. I do not want users to
achuithb
2013/02/06 00:23:03
Done.
|
| + dest='component_extensions_to_load_as_string', |
| + help='Loads additional component extensions.') |
| + group.add_option('--load-extension', |
| + dest='extensions_to_load_as_string', |
| + help='Loads additional extensions.') |
| parser.add_option_group(group) |
| # Page set options |
| @@ -151,6 +163,18 @@ |
| self.extra_browser_args_as_string) # pylint: disable=E1101 |
| self.extra_browser_args.extend(tmp) |
| delattr(self, 'extra_browser_args_as_string') |
| + if self.component_extensions_to_load_as_string: # pylint: disable=E1101 |
|
nduca
2013/02/01 00:25:50
you dont need this
achuithb
2013/02/06 00:23:03
Done.
|
| + paths = self.component_extensions_to_load_as_string.split(',') |
| + self.extensions_to_load.extend( |
| + [ExtensionToLoad(ext_path, True) |
| + for ext_path in paths]) |
| + delattr(self, 'component_extensions_to_load_as_string') |
| + if self.extensions_to_load_as_string: # pylint: disable=E1101 |
| + paths = self.extensions_to_load_as_string.split(',') |
| + self.extensions_to_load.extend( |
| + [ExtensionToLoad(ext_path, False) |
| + for ext_path in paths]) |
| + delattr(self, 'component_extensions_to_load_as_string') |
| return ret |
| parser.parse_args = ParseArgs |
| return parser |