Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 11881043: Breakpad: Enable more logging in crash_service to debug flaky failures on Windows (Closed)

Created:
7 years, 11 months ago by Mark Seaborn
Modified:
7 years, 11 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Breakpad: Enable more logging in crash_service to debug flaky failures on Windows Two things are needed to get crash_service's VLOG(1) messages sent to stderr: * Pass --v=1 * Enable "SYSTEM_DEBUG_LOG" in InitLogging() Without these steps, only higher verbosity messages get sent to stderr. Note that crash_service's stderr works if stderr is a pipe but not if it's a Windows console. On a Buildbot slave, though, stderr is a pipe. BUG=169394 TEST=run_breakpad_browser_process_crash_test in nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177271

Patch Set 1 #

Patch Set 2 : Tidy comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/tools/crash_service/main.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark Seaborn
7 years, 11 months ago (2013-01-16 18:50:07 UTC) #1
Nick Bray (chromium)
LGTM to the NaCL stuff, but I'd be more confortable if you got sign off ...
7 years, 11 months ago (2013-01-16 20:21:57 UTC) #2
Mark Seaborn
+cpu for tools/crash_service, since you've reviewed my changes there before.
7 years, 11 months ago (2013-01-16 20:41:53 UTC) #3
cpu_(ooo_6.6-7.5)
did I father that child? darn. lgtm.
7 years, 11 months ago (2013-01-16 21:27:34 UTC) #4
Mark Seaborn
+thestig since I need an OWNERS review for chrome/tools/crash_service.
7 years, 11 months ago (2013-01-16 21:56:02 UTC) #5
Lei Zhang
7 years, 11 months ago (2013-01-16 22:05:09 UTC) #6
lgtm since cpu is happy with it.

Powered by Google App Engine
This is Rietveld 408576698