Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7340)

Unified Diff: chrome/tools/crash_service/main.cc

Issue 11881043: Breakpad: Enable more logging in crash_service to debug flaky failures on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tidy comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/crash_service/main.cc
diff --git a/chrome/tools/crash_service/main.cc b/chrome/tools/crash_service/main.cc
index ae802abbb8caf7e992d8b5b553651df1d5d1d385..8efa31aea1de1fcaf96a201e617d20d05d335f69 100644
--- a/chrome/tools/crash_service/main.cc
+++ b/chrome/tools/crash_service/main.cc
@@ -44,13 +44,15 @@ int __stdcall wWinMain(HINSTANCE instance, HINSTANCE, wchar_t* cmd_line,
GetCrashServiceDirectory(&operating_dir);
FilePath log_file = operating_dir.Append(kStandardLogFile);
- // Logging to a file with pid, tid and timestamp.
+ // Logging to stderr (to help with debugging failures on the
+ // buildbots) and to a file.
logging::InitLogging(
log_file.value().c_str(),
- logging::LOG_ONLY_TO_FILE,
+ logging::LOG_TO_BOTH_FILE_AND_SYSTEM_DEBUG_LOG,
logging::LOCK_LOG_FILE,
logging::APPEND_TO_OLD_LOG_FILE,
logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS);
+ // Logging with pid, tid and timestamp.
logging::SetLogItems(true, true, true, false);
VLOG(1) << "session start. cmdline is [" << cmd_line << "]";
« no previous file with comments | « no previous file | ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698