ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py - Issue 11881043: Breakpad: Enable more logging in crash_service to debug flaky failures on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py

Issue 11881043: Breakpad: Enable more logging in crash_service to debug flaky failures on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tidy comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py

diff --git a/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py b/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py

index 5e7484f403565f38a0d229951168e9df4de49f3b..cc3d14b80e9b6d008d245e7fee4b9ff9082fc4cc 100755

--- a/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py

+++ b/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py

@@ -42,6 +42,7 @@ def StartCrashService(browser_path, dumps_dir, windows_pipe_name,

# Find crash_service.exe relative to chrome.exe. This is a bit icky.

browser_dir = os.path.dirname(browser_path)

proc = subprocess.Popen([os.path.join(browser_dir, crash_service_exe),

+ '--v=1', # Verbose output for debugging failures

'--dumps-dir=%s' % dumps_dir,

'--pipe-name=%s' % windows_pipe_name])

« no previous file with comments | « chrome/tools/crash_service/main.cc ('k') | no next file » | no next file with comments »