Issue 1188073003: Return void from array setters since the return value needs to be ignored

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188073003: Return void from array setters since the return value needs to be ignored (Closed)

Created:
5 years, 6 months ago by Toon Verwaest

Modified:
5 years, 6 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Return void from array setters since the return value needs to be ignored BUG=v8:4137 LOG=n Committed: https://crrev.com/72d6ed749b852531e5980264214063f41547a064 Cr-Commit-Position: refs/heads/master@{#29113}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -120 lines)			Patch
M	src/elements.h	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/elements.cc	View	4 chunks	+16 lines, -20 lines	0 comments	Download
M	src/objects.h	View	12 chunks	+33 lines, -36 lines	0 comments	Download
M	src/objects.cc	View	6 chunks	+39 lines, -54 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188073003/1

5 years, 6 months ago (2015-06-18 12:23:09 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-18 12:52:06 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/72d6ed749b852531e5980264214063f41547a064
Cr-Commit-Position: refs/heads/master@{#29113}